-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Why there is that gradient background at the bottom of the sidebar? #513
Comments
I don't like it either, but it probably indicates that there are other API categories below the visible ones. |
@dkfiresky nodejs/node#4748 describes your problem and a fix for it. If I use Safari with El Cap and the latest docs I can't see a gradient. |
The bugged gradient on Safari was fixed in nodejs/node#4748 and the fix has been released with the 5.6.0 docs a few hours ago, so you should see it working as intended now: The purpose is simply to indicate the scrollability of the sidebar, which might not be obvious because scrollbars are hidden. |
I wasn't seeing this, could you check if it's still an issue right now? |
@silverwind I confirm it is on https://nodejs.org/dist/latest-v4.x/docs/api/ |
@stevemao that's because the backport of nodejs/node#4748 hasn't been released yet. It's a bit unfortunate, but we have to wait for the next LTS release for the 4.x docs. |
Why simply showing scrollbars is not enough for indication of more content in the sidebar? It looks like overkill for me. Also the text color almost matches the gradient color (as posted in original screenshot) which makes text unreadable. |
I was going for a more "modern" style, and I think it looks cleaner without a scrollbar.
The rendering in your original screenshot was a bug. Chrome, Firefox and IE didn't show it, and I learned my lesson for not testing Safari :) |
@dkfiresky that behaviour is very browser-specific (Chromes does bubble the scroll event when the limit is reached, Firefox does not) from what I've tested, but I assume improvements can be made to have make it behave more like http://devdocs.io/node/ for example. |
I'm working on the scrolling issues and other misc things on the API docs's CSS. |
They got nice scrolling, and I think they somehow prevent scrolling on areas which are not under the mouse cursor. |
@dkfiresky yes, I already figured out how they do it, took me some time though 😉 See nodejs/node#5198 for my propsed changes. |
Well done, @silverwind 👍 I will close this issue as soon as your pull request will be merged. |
I really think |
Yeah that'd be my preference as well for faster propagation of stuff like this. On the other hand, it's kind of nice that each API release has its own standalone package of docs. |
I close this issue now, as my questions were resolved. Thanks everyone for participation. |
I'm sorry, but it looks so ugly...
The text was updated successfully, but these errors were encountered: