Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.x backport: fs: make SyncWriteStream inherit from Writable #9030

Closed
wants to merge 1 commit into from
Closed

v6.x backport: fs: make SyncWriteStream inherit from Writable #9030

wants to merge 1 commit into from

Commits on Oct 11, 2016

  1. fs: make SyncWriteStream inherit from Writable 

    Make the internal `SyncWriteStream` a proper `stream.Writable`
subclass. This allows for quite a bit of simplification, since
`SyncWriteStream` predates the streams2/streams3 implementations.

Fixes: nodejs#8828
PR-URL: nodejs#8830
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
    @addaleax
    addaleax committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    55e9c3a View commit details
    Browse the repository at this point in the history