From bfb97b3b98959dfdc51e62617235d656a65046f0 Mon Sep 17 00:00:00 2001 From: Gibson Fahnestock Date: Mon, 10 Oct 2016 14:46:04 +0100 Subject: [PATCH 1/4] doc: add s390 and ppc architecture labels Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label. --- doc/onboarding-extras.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index 30bc3226bb4ea1..e8b7c8ca589e03 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -76,10 +76,10 @@ Please use these when possible / appropriate ### Other Labels * Operating system labels - * `os x`, `windows`, `solaris` + * `os x`, `windows`, `solaris`, `aix` * No linux, linux is the implied default * Architecture labels - * `arm`, `mips` + * `arm`, `mips`, `s390`, `ppc` * No x86{_64}, since that is the implied default * `lts-agenda`, `lts-watch-v*` * tag things that should be discussed to go into LTS or should go into a specific LTS branch From 8c58ff9d3e75b04f1dbc2293765451e5e6491dc1 Mon Sep 17 00:00:00 2001 From: Gibson Fahnestock Date: Mon, 10 Oct 2016 14:44:27 +0100 Subject: [PATCH 2/4] doc: add teams for platform-specific issues Specifies teams to cc for platform specific issues - Existing teams: @nodejs/platform-arm, @nodejs/platform-freebsd, and @nodejs/platform-windows - New teams: @nodejs/platform-s390, @nodejs/platform-aix - Changed name: @nodejs/platform-solaris -> @nodejs/platform-smartos --- doc/onboarding-extras.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index e8b7c8ca589e03..66c55c1ccc43cd 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -29,6 +29,7 @@ | upgrading c-ares | @jbergstroem | | upgrading http-parser | @jbergstroem, @nodejs/http | | upgrading libuv | @saghul | +| platform specific | @nodejs/platform-{aix,arm,freebsd,macos,ppc,smartos,s390,windows} | When things need extra attention, are controversial, or `semver-major`: @nodejs/ctc From c80e29c545998fb705cbcf9557b2bfcbca283db2 Mon Sep 17 00:00:00 2001 From: Gibson Fahnestock Date: Mon, 10 Oct 2016 14:45:08 +0100 Subject: [PATCH 3/4] doc: change solaris tag to smartos --- doc/onboarding-extras.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index 66c55c1ccc43cd..3a86819e205fd5 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -77,7 +77,7 @@ Please use these when possible / appropriate ### Other Labels * Operating system labels - * `os x`, `windows`, `solaris`, `aix` + * `os x`, `windows`, `smartos`, `aix` * No linux, linux is the implied default * Architecture labels * `arm`, `mips`, `s390`, `ppc` From 93228c36a9deb07482d2ef4c17345851bb929c45 Mon Sep 17 00:00:00 2001 From: Gibson Fahnestock Date: Tue, 11 Oct 2016 08:31:57 +0100 Subject: [PATCH 4/4] doc: change os x tag to macos --- doc/onboarding-extras.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index 3a86819e205fd5..476e0046138279 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -77,7 +77,7 @@ Please use these when possible / appropriate ### Other Labels * Operating system labels - * `os x`, `windows`, `smartos`, `aix` + * `macos`, `windows`, `smartos`, `aix` * No linux, linux is the implied default * Architecture labels * `arm`, `mips`, `s390`, `ppc`