Add platform specific teams to onboarding-extras #9009

gibfahn · 2016-10-10T17:02:31Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

This is three separate changes (which can probably be squashed on landing):

EDIT: To clarify, the label changes haven't been done yet. I guess it makes sense to do it as part of the landing process (cc. @Fishrock123 )

1. Add OS/ARCH labels for `aix`, `ppc`, and `s390`:

Should be non-controversial, but requires the labels to be created

2. Change `solaris` tag to `smartos`:

Might make sense as per release builds: rename sunos to smartos build#500, if the existing labels update (but I defer to @nodejs/platform-solaris )

3. Add teams for platform-specific issues

Adds platform-specific teams as per release builds: rename sunos to smartos build#500 (comment)
Already existing teams: @nodejs/platform-arm , @nodejs/platform-freebsd , and @nodejs/platform-windows
New teams: @nodejs/platform-s390, @nodejs/platform-aix Edit: @nodejs/platform-macos
Changed team name: @nodejs/platform-solaris -> @nodejs/platform-smartos

Members for new teams:

Feel free to volunteer!

All three: @mhdawson @gireeshpunathil @gibfahn @joransiu @sxa555 @bnoordhuis @richardlau @jbajwa @john-yan
@nodejs/platform-s390:
@nodejs/platform-aix:
@nodejs/platform-ppc:

Do members of teams need to be collaborators? EDIT: I think the answer is yes

jasnell

LGTM

imyller · 2016-10-11T06:07:59Z

Apple has updated branding:

macOS (originally named "Mac OS X" until 2012 and then "OS X" until 2016)

How about also changing os x label to macos (or more generic mac)?

gibfahn · 2016-10-11T07:32:48Z

@imyller macos sounds good to me, added.

imyller · 2016-10-11T07:38:19Z

Is there interest for adding @nodejs/platform-mac ?

gibfahn · 2016-10-11T11:14:36Z

@imyller I think it makes sense as long as there are macOS specific issues that don't show up on Linux. Edit: Added @nodejs/platform-macos

mhdawson · 2016-10-11T13:56:20Z

I think we should also have:

platform-ppc: @mhdawson @gireeshpunathil @gibfahn @bnoordhuis @sxa555 @jbajwa

and add @sxa555 and @jbajwa to: platform-aix and platform-ppc

There is also a doc somewhere that provides guidance on who to cc for issues, we should probably update that to cover these new groups.

Fishrock123 · 2016-10-11T14:51:53Z

doc/onboarding-extras.md

@@ -76,10 +77,10 @@ Please use these when possible / appropriate
 ### Other Labels

 * Operating system labels
-  * `os x`, `windows`, `solaris`
+  * `macos`, `windows`, `smartos`, `aix`


aside: this has not yet been changed

gibfahn · 2016-10-11T15:55:17Z

@mhdawson

I think we should also have: platform-ppc: @mhdawson @gireeshpunathil @gibfahn @bnoordhuis @sxa555 @jbajwa and add @sxa555 and @jbajwa to: platform-aix and platform-ppc

Is there a need for a platform-ppc separately from platform-aix? Would that be for ppcBE and ppcLE Linux specific issues? I'm not sure how often that would actually have to be used.
I'm pretty sure that people have to be collaborators to be added to teams.

There is also a doc somewhere that provides guidance on who to cc for issues, we should probably update that to cover these new groups.

Assuming you mean https://github.com/nodejs/node/blob/master/doc/onboarding-extras.md#who-to-cc-in-issues, that's covered in this PR.

misterdjules

LGTM

jasnell

LGTM

mhdawson · 2016-10-11T17:58:30Z

@gibfahn Linux on P uses ppc and is not related to AIX. platform-ppc (or maybe something better) would be for issues on Linux on P as opposed to AIX.

mhdawson · 2016-10-11T17:59:40Z

@gibfahn I think we have people in teams for WGs who are not collaborators. @mikeal any issue with adding people to the org who are not collaborators so they can be added to a team ?

mhdawson · 2016-10-11T18:00:57Z

@gibfahn yup https://github.com/nodejs/node/blob/master/doc/onboarding-extras.md#who-to-cc-in-issues was that I was thinking about. I should have looked more closely.

gibfahn · 2016-10-11T22:32:00Z

@mhdawson If that's possible then great! I'll update.

imyller

LGTM

Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label.

Specifies teams to cc for platform specific issues - Existing teams: @nodejs/platform-arm, @nodejs/platform-freebsd, and @nodejs/platform-windows - New teams: @nodejs/platform-s390, @nodejs/platform-aix - Changed name: @nodejs/platform-solaris -> @nodejs/platform-smartos

joransiu · 2016-10-13T17:20:52Z

I'd be interested in joining the PPC, AIX and s390 teams.

jasnell

LGTM

Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label. PR-URL: #9009 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Specifies teams to cc for platform specific issues - Existing teams: @nodejs/platform-arm, @nodejs/platform-freebsd, and @nodejs/platform-windows - New teams: @nodejs/platform-s390, @nodejs/platform-aix - Changed name: @nodejs/platform-solaris -> @nodejs/platform-smartos PR-URL: #9009 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9009 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

jasnell · 2016-10-24T14:15:16Z

Landed in c659c9d...5532a7a

gibfahn · 2016-10-24T15:34:24Z

@mhdawson I'm getting an error when I try to add someone who isn't a collaborator to a team. I guess gireeshpunathil, joransiu, sxa555, richardlau, jbajwa and john-yan will have to be added to the org (if that's okay, would be good to get confifrmation from @mikeal), which I don't have access to do. I also don't think I can create the aix, ppc, and s390 labels.

@misterdjules I'll leave the changing of @nodejs/platform-solaris -> @nodejs/platform-smartos and the solaris tag to smartos to you.

@imyller I added you to @nodejs/platform-macos , again I don't think I can change the label, maybe @jasnell could do that?

misterdjules · 2016-10-24T16:11:41Z

@misterdjules I'll leave the changing of @nodejs/platform-solaris -> @nodejs/platform-smartos and the solaris tag to smartos to you.

Done.

Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label. PR-URL: #9009 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Specifies teams to cc for platform specific issues - Existing teams: @nodejs/platform-arm, @nodejs/platform-freebsd, and @nodejs/platform-windows - New teams: @nodejs/platform-s390, @nodejs/platform-aix - Changed name: @nodejs/platform-solaris -> @nodejs/platform-smartos PR-URL: #9009 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9009 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

MylesBorins · 2016-11-17T22:06:19Z

as the platform support for v4 and v6 are different I am opting to not land this. @gibfahn please feel free to manually backport

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 10, 2016

jasnell approved these changes Oct 10, 2016

View reviewed changes

gibfahn force-pushed the add-teams branch 2 times, most recently from a548be2 to 25fa706 Compare October 11, 2016 11:18

Fishrock123 reviewed Oct 11, 2016

View reviewed changes

misterdjules approved these changes Oct 11, 2016

View reviewed changes

jasnell approved these changes Oct 11, 2016

View reviewed changes

imyller approved these changes Oct 12, 2016

View reviewed changes

doc: add s390 and ppc architecture labels

bfb97b3

Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label.

gibfahn force-pushed the add-teams branch from 25fa706 to a8354e9 Compare October 12, 2016 07:35

gibfahn added 3 commits October 12, 2016 18:18

doc: change solaris tag to smartos

c80e29c

doc: change os x tag to macos

93228c3

gibfahn force-pushed the add-teams branch from a8354e9 to 93228c3 Compare October 12, 2016 17:19

jasnell approved these changes Oct 14, 2016

View reviewed changes

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

mhdawson approved these changes Oct 24, 2016

View reviewed changes

jasnell closed this Oct 24, 2016

gibfahn added macos Issues and PRs related to the macOS platform / OSX. smartos Issues and PRs related to the SmartOS platform. labels Oct 24, 2016

MylesBorins added dont-land-on-v4.x labels Nov 17, 2016

gibfahn deleted the add-teams branch December 16, 2016 11:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add platform specific teams to onboarding-extras #9009

Add platform specific teams to onboarding-extras #9009

gibfahn commented Oct 10, 2016 •

edited

Loading

jasnell left a comment

imyller commented Oct 11, 2016

gibfahn commented Oct 11, 2016

imyller commented Oct 11, 2016

gibfahn commented Oct 11, 2016 •

edited

Loading

mhdawson commented Oct 11, 2016

Fishrock123 Oct 11, 2016

gibfahn commented Oct 11, 2016

misterdjules left a comment

jasnell left a comment

mhdawson commented Oct 11, 2016

mhdawson commented Oct 11, 2016

mhdawson commented Oct 11, 2016

gibfahn commented Oct 11, 2016

imyller left a comment

joransiu commented Oct 13, 2016

jasnell left a comment

jasnell commented Oct 24, 2016

gibfahn commented Oct 24, 2016

misterdjules commented Oct 24, 2016

MylesBorins commented Nov 17, 2016

Add platform specific teams to onboarding-extras #9009

Add platform specific teams to onboarding-extras #9009

Conversation

gibfahn commented Oct 10, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

1. Add OS/ARCH labels for aix, ppc, and s390:

2. Change solaris tag to smartos:

3. Add teams for platform-specific issues

Members for new teams:

jasnell left a comment

Choose a reason for hiding this comment

imyller commented Oct 11, 2016

gibfahn commented Oct 11, 2016

imyller commented Oct 11, 2016

gibfahn commented Oct 11, 2016 • edited Loading

mhdawson commented Oct 11, 2016

Fishrock123 Oct 11, 2016

Choose a reason for hiding this comment

gibfahn commented Oct 11, 2016

misterdjules left a comment

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

mhdawson commented Oct 11, 2016

mhdawson commented Oct 11, 2016

mhdawson commented Oct 11, 2016

gibfahn commented Oct 11, 2016

imyller left a comment

Choose a reason for hiding this comment

joransiu commented Oct 13, 2016

jasnell left a comment

Choose a reason for hiding this comment

jasnell commented Oct 24, 2016

gibfahn commented Oct 24, 2016

misterdjules commented Oct 24, 2016

MylesBorins commented Nov 17, 2016

gibfahn commented Oct 10, 2016 •

edited

Loading

1. Add OS/ARCH labels for `aix`, `ppc`, and `s390`:

2. Change `solaris` tag to `smartos`:

gibfahn commented Oct 11, 2016 •

edited

Loading