-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: reserve 132 for Electron 34 #55306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reserves NMV 132 for Electron 34
richardlau
approved these changes
Oct 7, 2024
mlaurencin
added a commit
to electron/electron
that referenced
this pull request
Oct 7, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
5 tasks
RedYetiDev
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 7, 2024
jakecastelli
approved these changes
Oct 7, 2024
richardlau
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 7, 2024
UlisesGascon
approved these changes
Oct 8, 2024
mhdawson
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 9, 2024
Landed in e79ae1b |
VerteDinde
pushed a commit
to electron/electron
that referenced
this pull request
Oct 9, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
aduh95
added
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
labels
Oct 9, 2024
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This PR reserves NMV 132 for Electron 34 PR-URL: nodejs#55306 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
This PR reserves NMV 132 for Electron 34 PR-URL: nodejs#55306 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reserves NMV 132 for Electron 34