Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reserve 132 for Electron 34 #55306

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

mlaurencin
Copy link
Contributor

This PR reserves NMV 132 for Electron 34

This PR reserves NMV 132 for Electron 34
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 7, 2024
mlaurencin added a commit to electron/electron that referenced this pull request Oct 7, 2024
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 7, 2024
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit e79ae1b into nodejs:main Oct 9, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e79ae1b

VerteDinde pushed a commit to electron/electron that referenced this pull request Oct 9, 2024
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 9, 2024
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
This PR reserves NMV 132 for Electron 34

PR-URL: nodejs#55306
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
This PR reserves NMV 132 for Electron 34

PR-URL: nodejs#55306
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants