-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove relative limitation to pm #52648
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:remove-relative-mention
Apr 24, 2024
Merged
doc: remove relative limitation to pm #52648
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:remove-relative-mention
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
H4ad
approved these changes
Apr 22, 2024
mhdawson
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RedYetiDev
added
experimental
Issues and PRs related to experimental features.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
permission
Issues and PRs related to the Permission Model
labels
Apr 22, 2024
benjamingr
approved these changes
Apr 23, 2024
marco-ippolito
approved these changes
Apr 23, 2024
RedYetiDev
approved these changes
Apr 23, 2024
lpinca
approved these changes
Apr 23, 2024
MylesBorins
approved these changes
Apr 24, 2024
meixg
approved these changes
Apr 24, 2024
MoLow
approved these changes
Apr 24, 2024
H4ad
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 24, 2024
trivikr
approved these changes
Apr 24, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 24, 2024
Landed in 708bffa |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52648 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52648 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52648 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52648 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
experimental
Issues and PRs related to experimental features.
permission
Issues and PRs related to the Permission Model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was resolved by #50758