Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: improve creation time of EventTarget #52410

Closed
wants to merge 1 commit into from

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Apr 7, 2024

Benchmarks

may not be accurate until nodejs/build#3657 (comment) is resolved

Benchmark URL

No change:

23:20:03                                                         confidence improvement accuracy (*)   (**)  (***)
23:20:03 events/eventtarget-add-remove.js nListener=10 n=1000000                 0.01 %       ±0.63% ±0.84% ±1.10%
23:20:03 events/eventtarget-add-remove.js nListener=5 n=1000000                  0.31 %       ±0.52% ±0.69% ±0.90%
23:20:03 events/eventtarget-creation.js n=1000000                               -0.59 %       ±2.34% ±3.11% ±4.04%
23:20:03 events/eventtarget.js listeners=1 n=1000000                            -0.26 %       ±0.38% ±0.51% ±0.66%
23:20:03 events/eventtarget.js listeners=10 n=1000000                            0.25 %       ±0.38% ±0.50% ±0.66%
23:20:03 events/eventtarget.js listeners=5 n=1000000                            -0.34 %       ±0.94% ±1.25% ±1.63%
23:20:03 

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 7, 2024
@rluvaton rluvaton added performance Issues and PRs related to the performance of Node.js. eventtarget Issues and PRs related to the EventTarget implementation. needs-benchmark-ci PR that need a benchmark CI run. labels Apr 7, 2024
@rluvaton rluvaton mentioned this pull request Apr 7, 2024
@rluvaton rluvaton force-pushed the improve-event-target-creation branch from 2454331 to 530cc13 Compare April 7, 2024 20:20
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024
@nodejs-github-bot
Copy link
Collaborator

@rluvaton rluvaton closed this Apr 7, 2024
@rluvaton rluvaton deleted the improve-event-target-creation branch April 7, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eventtarget Issues and PRs related to the EventTarget implementation. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants