test_runner: run afterEach hooks in correct order #52239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the test runner afterEach hook so that the current test's afterEach hooks run before any ancestor afterEach hooks. Fixes: nodejs#51671
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
approved these changes
Mar 28, 2024
github-actions
bot
removed
the
request-ci
atlowChemi
approved these changes
Mar 28, 2024
Comment on lines
+565
to
+566
| ArrayPrototypeSplice(this.hooks[name], this.hooks.ownAfterEachCount, 0, hook); | ||
| this.hooks.ownAfterEachCount++; |
There was a problem hiding this comment.
Suggested change
| ArrayPrototypeSplice(this.hooks[name], this.hooks.ownAfterEachCount, 0, hook); | |
| this.hooks.ownAfterEachCount++; | |
| ArrayPrototypeSplice(this.hooks[name], this.hooks.ownAfterEachCount++, 0, hook); |
There was a problem hiding this comment.
I personally find that a little less readable, only because the splice line is already a bit busy.
cjihrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7c02486 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
This commit updates the test runner afterEach hook so that the current test's afterEach hooks run before any ancestor afterEach hooks. Fixes: #51671 PR-URL: #52239 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
This commit updates the test runner afterEach hook so that the current test's afterEach hooks run before any ancestor afterEach hooks. Fixes: #51671 PR-URL: #52239 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the test runner afterEach hook so that the current test's afterEach hooks run before any ancestor afterEach hooks.
Fixes: #51671