toosl: fix error reported by coverity in js2c.cc #52142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reports from coverity }
614
615 if (simplified_count > 0) {
CID 347888:Invalid type in argument to printf format specifier (PRINTF_ARGS) [ "select issue" ]
616 Debug("Simplified %d characters, ", simplified_count);
CID 347889: (#1 of 1): Invalid type in argument to printf format specifier (PRINTF_ARGS)
invalid_type: Argument code_size to format specifier %d was expected to have type int but has type unsigned long.["show details"]
CID 347887:Invalid type in argument to printf format specifier (PRINTF_ARGS) [ "select issue" ]
617 Debug("old size %d, new size %d\n", code_size, simplified->size());
618 return true;
619 }
620 return false; |
Coverity reported using the wrong argument types to printf Signed-off-by: Michael Dawson <[email protected]>
anonrig
approved these changes
Mar 19, 2024
|
There's a typo in the PR title 😅 |
lpinca
approved these changes
Mar 19, 2024
|
@meyfa had already fixed the typo in the commit, but just fixed in the PR title. |
github-actions
bot
removed
the
request-ci
mhdawson
added a commit
that referenced
this pull request
Mar 25, 2024
Coverity reported using the wrong argument types to printf Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52142 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in Landed in c43a944 |
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Mar 25, 2024
Coverity reported using the wrong argument types to printf Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#52142 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Coverity reported using the wrong argument types to printf Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#52142 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Coverity reported using the wrong argument types to printf Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52142 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Coverity reported using the wrong argument types to printf Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52142 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity reported using the wrong argument types
to printf