From 616357a7dcb0b5f8e169403397240ceec5c3cbaf Mon Sep 17 00:00:00 2001 From: Niya Shiyas Date: Sat, 23 Sep 2023 14:20:56 +0530 Subject: [PATCH 1/4] test: replace forEach with for..of in test-net-isipv4.js --- test/parallel/test-net-isipv4.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-net-isipv4.js b/test/parallel/test-net-isipv4.js index 8f5c30569ce988..a478568d952bc4 100644 --- a/test/parallel/test-net-isipv4.js +++ b/test/parallel/test-net-isipv4.js @@ -37,10 +37,10 @@ const v4not = [ '192.168.0.2000000000', ]; -v4.forEach((ip) => { +for(const ip of v4) { assert.strictEqual(net.isIPv4(ip), true); -}); +}; -v4not.forEach((ip) => { +for(const ip of v4not) { assert.strictEqual(net.isIPv4(ip), false); -}); +}; From 1f4c1255b48691a928fda415628bbce0e20f1957 Mon Sep 17 00:00:00 2001 From: Niya Shiyas Date: Sun, 24 Sep 2023 15:30:07 +0530 Subject: [PATCH 2/4] test: replace forEach with for..of in test-net-isipv4.js --- test/parallel/test-net-isipv4.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-net-isipv4.js b/test/parallel/test-net-isipv4.js index a478568d952bc4..ce867a4fad288e 100644 --- a/test/parallel/test-net-isipv4.js +++ b/test/parallel/test-net-isipv4.js @@ -39,8 +39,8 @@ const v4not = [ for(const ip of v4) { assert.strictEqual(net.isIPv4(ip), true); -}; +} for(const ip of v4not) { assert.strictEqual(net.isIPv4(ip), false); -}; +} From 524d5bec6936621734d9a3ca3de871cbc9032446 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Mon, 9 Oct 2023 22:46:30 +0200 Subject: [PATCH 3/4] Update test/parallel/test-net-isipv4.js --- test/parallel/test-net-isipv4.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-net-isipv4.js b/test/parallel/test-net-isipv4.js index ce867a4fad288e..b12c366e9abdaf 100644 --- a/test/parallel/test-net-isipv4.js +++ b/test/parallel/test-net-isipv4.js @@ -37,7 +37,7 @@ const v4not = [ '192.168.0.2000000000', ]; -for(const ip of v4) { +for (const ip of v4) { assert.strictEqual(net.isIPv4(ip), true); } From ca61146f943a1e12ca9da15660ae0ed9b1e54c59 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Mon, 9 Oct 2023 22:46:37 +0200 Subject: [PATCH 4/4] Update test/parallel/test-net-isipv4.js --- test/parallel/test-net-isipv4.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-net-isipv4.js b/test/parallel/test-net-isipv4.js index b12c366e9abdaf..2c478e6ac678b7 100644 --- a/test/parallel/test-net-isipv4.js +++ b/test/parallel/test-net-isipv4.js @@ -41,6 +41,6 @@ for (const ip of v4) { assert.strictEqual(net.isIPv4(ip), true); } -for(const ip of v4not) { +for (const ip of v4not) { assert.strictEqual(net.isIPv4(ip), false); }