[v20.x backport] stream: improve tee perf by reduce ReflectConstruct usages
#49620
+96
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
rluvaton
changed the title
ReflectConstruct usagesReflectConstruct usages
Merged
also added more webstream creation benchmarks PR-URL: nodejs#49546 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
rluvaton
force-pushed
the
backport-49546-to-v20.x
branch
from
8eb0194 to
3f7b05e
Compare
github-actions
bot
removed
the
request-ci
14 tasks
UlisesGascon
approved these changes
Sep 13, 2023
benjamingr
approved these changes
Sep 13, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 13, 2023
also added more webstream creation benchmarks PR-URL: #49546 Backport-PR-URL: #49620 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 8aac95d |
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added more webstream creation benchmarks
PR-URL: #49546
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Matteo Collina [email protected]