typings: fix missing property in ExportedHooks
#49567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
fast-track
|
Review requested:
|
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
nodejs-github-bot
added
esm
GeoffreyBooth
approved these changes
Sep 8, 2023
JakobJingleheimer
approved these changes
Sep 9, 2023
UlisesGascon
approved these changes
Sep 9, 2023
VoltrexKeyva
approved these changes
Sep 9, 2023
GeoffreyBooth
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/49567 ✔ Done loading data for nodejs/node/pull/49567 ----------------------------------- PR info ------------------------------------ Title typings: fix missing property in `ExportedHooks` (#49567) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:exported-hooks-initialize -> nodejs:main Labels esm, fast-track, needs-ci, typings, commit-queue-squash Commits 1 - typings: fix missing property in `ExportedHooks` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49567 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49567 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 Sep 2023 21:20:31 GMT ✔ Approvals: 3 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6131683938 |
nodejs-github-bot
added
the
commit-queue-failed
GeoffreyBooth
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49567 ✔ Done loading data for nodejs/node/pull/49567 ----------------------------------- PR info ------------------------------------ Title typings: fix missing property in `ExportedHooks` (#49567) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:exported-hooks-initialize -> nodejs:main Labels esm, fast-track, typings, commit-queue-squash Commits 1 - typings: fix missing property in `ExportedHooks` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49567 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49567 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 Sep 2023 21:20:31 GMT ✔ Approvals: 3 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6131826631 |
github-actions
bot
removed
the
request-ci
GeoffreyBooth
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49567 ✔ Done loading data for nodejs/node/pull/49567 ----------------------------------- PR info ------------------------------------ Title typings: fix missing property in `ExportedHooks` (#49567) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:exported-hooks-initialize -> nodejs:main Labels esm, fast-track, typings, commit-queue-squash Commits 1 - typings: fix missing property in `ExportedHooks` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49567 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49567 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 Sep 2023 21:20:31 GMT ✔ Approvals: 3 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222 ℹ This PR is being fast-tracked ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-09-09T17:55:08Z: https://ci.nodejs.org/job/node-test-pull-request/53843/ - Querying data for job/node-test-pull-request/53843/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6132755646 |
MoLow
approved these changes
Sep 9, 2023
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5bb0cb2 |
This was referenced Sep 10, 2023
This was referenced Sep 13, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49567 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49567 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49567 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #49567 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49567 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49567 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.