Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use internal fileURLToPath #49558

Merged
merged 1 commit into from
Sep 10, 2023
Merged

lib: use internal fileURLToPath #49558

merged 1 commit into from
Sep 10, 2023

Conversation

deokjinkim
Copy link
Contributor

For internal usage, internal/url should be used.

Refs: #49553

@deokjinkim
lib: use internal fileURLToPath
2fea2ec 
For internal usage, `internal/url` should be used.

Refs: nodejs#49553
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 8, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53818/

@github-actions github-actions bot mentioned this pull request Sep 9, 2023
Open
24 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53832/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53848/

@github-actions github-actions bot mentioned this pull request Sep 10, 2023
Open
19 tasks
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit b3fc917 into nodejs:main Sep 10, 2023
37 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b3fc917

@LiviaMedeiros LiviaMedeiros mentioned this pull request Sep 10, 2023
Closed
This was referenced Sep 11, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@deokjinkim @ruyadorno
lib: use internal fileURLToPath
f62d649 
For internal usage, `internal/url` should be used.

Refs: #49553
PR-URL: #49558
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@deokjinkim @alexfernandez
lib: use internal fileURLToPath
d67aefd 
For internal usage, `internal/url` should be used.

Refs: nodejs#49553
PR-URL: nodejs#49558
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@rluvaton rluvaton rluvaton approved these changes

@aduh95 aduh95 aduh95 approved these changes

@JungMinu JungMinu JungMinu approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@deokjinkim @nodejs-github-bot @anonrig @JungMinu @aduh95 @rluvaton @atlowChemi @LiviaMedeiros