Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage of Module.register and initialize hook #49532

Merged
merged 1 commit into from
Sep 10, 2023
Merged

test: increase coverage of Module.register and initialize hook #49532

merged 1 commit into from
Sep 10, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 7, 2023

I recommend reviewing with whitespaces turned off.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 7, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 7, 2023

/cc @nodejs/loaders

@GeoffreyBooth
Copy link
Member

How does this relate to #49529?

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 7, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 7, 2023

How does this relate to #49529?

Hum both PRs are dealing with the same Module.register API, but apart from that they are hardly related.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2023
@GeoffreyBooth
Copy link
Member

apart from that they are hardly related.

As in, none of these tests involve the initialize return value.

That’s fine, I was just hoping that they weren’t in conflict, and it sounds like they aren’t.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53791/

@aduh95
Copy link
Contributor Author

aduh95 commented Sep 7, 2023

I was just hoping that they weren’t in conflict, and it sounds like they aren’t.

They probably are in conflict, they are modifying the same lines in the test, for unrelated reasons.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53847/

@github-actions github-actions bot mentioned this pull request Sep 10, 2023
Open
19 tasks
@aduh95 aduh95 mentioned this pull request Sep 10, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53851/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53852/

@GeoffreyBooth GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit c159b90 into nodejs:main Sep 10, 2023
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c159b90

This was referenced Sep 11, 2023
Open
Open
@joyeecheung joyeecheung mentioned this pull request Sep 12, 2023
Closed
This was referenced Sep 13, 2023
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95 @ruyadorno
test: increase coverage of Module.register and initialize hook
ced25a9 
PR-URL: #49532
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@aduh95 @alexfernandez
test: increase coverage of Module.register and initialize hook
a5cc5d5 
PR-URL: nodejs#49532
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
test: increase coverage of Module.register and initialize hook
89dce06 
PR-URL: nodejs#49532
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
test: increase coverage of Module.register and initialize hook
866d646 
PR-URL: #49532
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: increase coverage of Module.register and initialize
6ddeff5 
PR-URL: nodejs/node#49532
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: increase coverage of Module.register and initialize
2311dc2 
PR-URL: nodejs/node#49532
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @GeoffreyBooth @nodejs-github-bot @anonrig @targos