From 5d2af02a1ffd653dacc0811f2971bf60544f7129 Mon Sep 17 00:00:00 2001
From: Moshe Atlow <moshe@atlow.co.il>
Date: Mon, 26 Jun 2023 01:03:28 +0300
Subject: [PATCH] child_process: support `Symbol.dispose`

---
 doc/api/child_process.md                    | 10 +++++++++
 lib/internal/child_process.js               |  7 ++++++
 test/parallel/test-child-process-destroy.js | 25 +++++++++++++++++++++
 3 files changed, 42 insertions(+)
 create mode 100644 test/parallel/test-child-process-destroy.js

diff --git a/doc/api/child_process.md b/doc/api/child_process.md
index 70345e9472c66e..2c644c61c5f1ad 100644
--- a/doc/api/child_process.md
+++ b/doc/api/child_process.md
@@ -1402,6 +1402,16 @@ setTimeout(() => {
 }, 2000);
 ```
 
+### `subprocess[Symbol.dispose]()`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental
+
+Calls [`subprocess.kill()`][] with `'SIGTERM'`.
+
 ### `subprocess.killed`
 
 <!-- YAML
diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
index fc7edbda57d320..2cad5aaf71cec9 100644
--- a/lib/internal/child_process.js
+++ b/lib/internal/child_process.js
@@ -12,6 +12,7 @@ const {
   ReflectApply,
   StringPrototypeSlice,
   Symbol,
+  SymbolDispose,
   Uint8Array,
 } = primordials;
 
@@ -516,6 +517,12 @@ ChildProcess.prototype.kill = function(sig) {
   return false;
 };
 
+ChildProcess.prototype[SymbolDispose] = function() {
+  if (!this.killed) {
+    this.kill();
+  }
+};
+
 
 ChildProcess.prototype.ref = function() {
   if (this._handle) this._handle.ref();
diff --git a/test/parallel/test-child-process-destroy.js b/test/parallel/test-child-process-destroy.js
new file mode 100644
index 00000000000000..50763bb0315e5d
--- /dev/null
+++ b/test/parallel/test-child-process-destroy.js
@@ -0,0 +1,25 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const spawn = require('child_process').spawn;
+const cat = spawn(common.isWindows ? 'cmd' : 'cat');
+
+cat.stdout.on('end', common.mustCall());
+cat.stderr.on('data', common.mustNotCall());
+cat.stderr.on('end', common.mustCall());
+
+cat.on('exit', common.mustCall((code, signal) => {
+  assert.strictEqual(code, null);
+  assert.strictEqual(signal, 'SIGTERM');
+  assert.strictEqual(cat.signalCode, 'SIGTERM');
+}));
+cat.on('exit', common.mustCall((code, signal) => {
+  assert.strictEqual(code, null);
+  assert.strictEqual(signal, 'SIGTERM');
+  assert.strictEqual(cat.signalCode, 'SIGTERM');
+}));
+
+assert.strictEqual(cat.signalCode, null);
+assert.strictEqual(cat.killed, false);
+cat[Symbol.dispose]();
+assert.strictEqual(cat.killed, true);