From 14c9c164fc5c7b6dffa481c8f5bb8239167dd856 Mon Sep 17 00:00:00 2001 From: Tony Gorez Date: Mon, 23 Jan 2023 10:10:09 +0100 Subject: [PATCH 1/5] doc: fix commit message using test instead of deps --- doc/contributing/maintaining-postject.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/contributing/maintaining-postject.md b/doc/contributing/maintaining-postject.md index 96746e22796900..b69c624a15daf0 100644 --- a/doc/contributing/maintaining-postject.md +++ b/doc/contributing/maintaining-postject.md @@ -12,12 +12,14 @@ Check that Node.js still builds and tests. ## Committing postject -Add postject: `git add --all test/fixtures/postject-copy` +* Add postject: `git add --all test/fixtures/postject-copy` -Commit the changes with a message like: +* Commit the changes: `git commit` + +* Add a message like: ```text -deps: update postject to 1.0.0-alpha.4 +test: update postject to Updated as described in doc/contributing/maintaining-postject.md. ``` From 9f20e4d3d930d4dd34552d170cc592c1796ac471 Mon Sep 17 00:00:00 2001 From: Tony Gorez Date: Mon, 23 Jan 2023 11:01:34 +0100 Subject: [PATCH 2/5] doc: reformat md --- doc/contributing/maintaining-postject.md | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/doc/contributing/maintaining-postject.md b/doc/contributing/maintaining-postject.md index b69c624a15daf0..5f3e421195126b 100644 --- a/doc/contributing/maintaining-postject.md +++ b/doc/contributing/maintaining-postject.md @@ -12,14 +12,12 @@ Check that Node.js still builds and tests. ## Committing postject -* Add postject: `git add --all test/fixtures/postject-copy` +1. Add postject: `git add --all test/fixtures/postject-copy` +2. Commit the changes: `git commit` +3. Add a message like: -* Commit the changes: `git commit` + ```text + test: update postject to -* Add a message like: - -```text -test: update postject to - -Updated as described in doc/contributing/maintaining-postject.md. -``` + Updated as described in doc/contributing/maintaining-postject.md. + ``` From 4135364890fb0a8ed3a448770ed73e2022d943cf Mon Sep 17 00:00:00 2001 From: Tony Gorez Date: Mon, 23 Jan 2023 11:04:09 +0100 Subject: [PATCH 3/5] ci: change label and subsystem --- .github/workflows/tools.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml index a056aa705bd246..ab7902eec9709e 100644 --- a/.github/workflows/tools.yml +++ b/.github/workflows/tools.yml @@ -78,8 +78,8 @@ jobs: ./tools/update-undici.sh fi - id: postject - subsystem: deps - label: dependencies + subsystem: test + label: test run: | NEW_VERSION=$(npm view postject dist-tags.latest) CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version") From c855f2fe7dc1c0bb55cdec4bbdcdf15b3723e690 Mon Sep 17 00:00:00 2001 From: Tony Gorez Date: Mon, 23 Jan 2023 11:18:49 +0100 Subject: [PATCH 4/5] doc: fix formatting issues --- doc/contributing/maintaining-postject.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/contributing/maintaining-postject.md b/doc/contributing/maintaining-postject.md index 5f3e421195126b..ee1a1db38453e0 100644 --- a/doc/contributing/maintaining-postject.md +++ b/doc/contributing/maintaining-postject.md @@ -12,12 +12,12 @@ Check that Node.js still builds and tests. ## Committing postject -1. Add postject: `git add --all test/fixtures/postject-copy` -2. Commit the changes: `git commit` +1. Add postject: `git add --all test/fixtures/postject-copy`. +2. Commit the changes: `git commit`. 3. Add a message like: - ```text - test: update postject to +```text +test: update postject to - Updated as described in doc/contributing/maintaining-postject.md. - ``` +Updated as described in doc/contributing/maintaining-postject.md. +``` From 37df3c71c5e8ed53faac57b00861175a5d24bfa0 Mon Sep 17 00:00:00 2001 From: Tony Gorez Date: Mon, 23 Jan 2023 14:15:43 +0100 Subject: [PATCH 5/5] doc: fix indentation for nested text snippet --- doc/contributing/maintaining-postject.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/contributing/maintaining-postject.md b/doc/contributing/maintaining-postject.md index ee1a1db38453e0..d01dc318e51c5c 100644 --- a/doc/contributing/maintaining-postject.md +++ b/doc/contributing/maintaining-postject.md @@ -16,8 +16,8 @@ Check that Node.js still builds and tests. 2. Commit the changes: `git commit`. 3. Add a message like: -```text -test: update postject to + ```text + test: update postject to -Updated as described in doc/contributing/maintaining-postject.md. -``` + Updated as described in doc/contributing/maintaining-postject.md. + ```