Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-api: avoid calling virtual methods in base's dtor #44424

Merged
merged 1 commit into from
Aug 31, 2022
Merged

node-api: avoid calling virtual methods in base's dtor #44424

merged 1 commit into from
Aug 31, 2022

Commits on Aug 28, 2022

  1. node-api: avoid calling virtual methods in base's dtor 

    Derived classes' fields are already destroyed if the virtual methods are
invoked in the base class's destructor. It is not safe to call virtual
methods in base's dtor.
    @legendecas
    legendecas committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    dd48302 View commit details
    Browse the repository at this point in the history