From 467a2a6aecb28508cd54f379682d72bc1281241d Mon Sep 17 00:00:00 2001 From: LiviaMedeiros Date: Thu, 4 Aug 2022 18:59:54 +0800 Subject: [PATCH 1/4] doc: add Retry CI in collaborator guide --- doc/contributing/collaborator-guide.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index c145ca8fce03df..a1590fb0580d00 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -253,6 +253,10 @@ current job but re-run everything else. Start a fresh CI if more than seven days have elapsed since the original failing CI as the compiled binaries for the Windows and ARM platforms are only kept for seven days. +If new changes are made on the pull request branch after latest Jenkins CI run, +a fresh CI run is required. It can be started by pressing "Retry" on the left +sidebar, or by adding `request-ci` label to the pull request. + #### Useful Jenkins CI jobs * [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/) From 5b61784f9efe50322d46b958fb1843fd77385f4e Mon Sep 17 00:00:00 2001 From: Livia Medeiros Date: Fri, 5 Aug 2022 03:30:35 +0800 Subject: [PATCH 2/4] squash: fixup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tobias Nießen --- doc/contributing/collaborator-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index a1590fb0580d00..6584c415cbc033 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -253,7 +253,7 @@ current job but re-run everything else. Start a fresh CI if more than seven days have elapsed since the original failing CI as the compiled binaries for the Windows and ARM platforms are only kept for seven days. -If new changes are made on the pull request branch after latest Jenkins CI run, +If new commits are pushed to the pull request branch after the latest Jenkins CI run, a fresh CI run is required. It can be started by pressing "Retry" on the left sidebar, or by adding `request-ci` label to the pull request. From b6c73d23ae4c65203554f2c68ebb1bbc2af59d61 Mon Sep 17 00:00:00 2001 From: Livia Medeiros Date: Fri, 5 Aug 2022 03:30:49 +0800 Subject: [PATCH 3/4] squash: fixup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tobias Nießen --- doc/contributing/collaborator-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index 6584c415cbc033..34068e6138fa5f 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -255,7 +255,7 @@ Windows and ARM platforms are only kept for seven days. If new commits are pushed to the pull request branch after the latest Jenkins CI run, a fresh CI run is required. It can be started by pressing "Retry" on the left -sidebar, or by adding `request-ci` label to the pull request. +sidebar, or by adding the `request-ci` label to the pull request. #### Useful Jenkins CI jobs From 57e4b895c2a8f22e24d6f15d143cc8acc1603c75 Mon Sep 17 00:00:00 2001 From: LiviaMedeiros Date: Fri, 5 Aug 2022 03:39:59 +0800 Subject: [PATCH 4/4] squash: fixup --- doc/contributing/collaborator-guide.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index 34068e6138fa5f..dfb23aa53156e7 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -253,9 +253,9 @@ current job but re-run everything else. Start a fresh CI if more than seven days have elapsed since the original failing CI as the compiled binaries for the Windows and ARM platforms are only kept for seven days. -If new commits are pushed to the pull request branch after the latest Jenkins CI run, -a fresh CI run is required. It can be started by pressing "Retry" on the left -sidebar, or by adding the `request-ci` label to the pull request. +If new commits are pushed to the pull request branch after the latest Jenkins +CI run, a fresh CI run is required. It can be started by pressing "Retry" on +the left sidebar, or by adding the `request-ci` label to the pull request. #### Useful Jenkins CI jobs