Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: register StreamBase while registering LibuvStreamWrap #43321

Merged
merged 2 commits into from
Jun 17, 2022
Merged

src: register StreamBase while registering LibuvStreamWrap #43321

merged 2 commits into from
Jun 17, 2022

Conversation

RaisinTen
Copy link
Contributor

This resolves this TODO -

node/src/stream_wrap.cc

Lines 111 to 112 in 71071f8

// TODO(joyee): StreamBase::RegisterExternalReferences() is called somewhere
// else but we may want to do it here too and guard it with a static flag.
.

Signed-off-by: Darshan Sen [email protected]

cc @joyeecheung

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 5, 2022
@RaisinTen RaisinTen force-pushed the src/register-StreamBase-while-registering-LibuvStreamWrap branch from cd7b929 to 371adec Compare June 5, 2022 12:41
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2022
@RaisinTen
src: add comment
3bb4e35 
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 13, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
16 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Jun 15, 2022
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Open
31 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44635/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2022
@nodejs-github-bot nodejs-github-bot merged commit ef70718 into nodejs:main Jun 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ef70718

@RaisinTen RaisinTen deleted the src/register-StreamBase-while-registering-LibuvStreamWrap branch June 17, 2022 08:47
This was referenced Jun 18, 2022
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@RaisinTen @targos
src: register StreamBase while registering LibuvStreamWrap
66ee1f1 
This resolves this TODO -
https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43321
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 18, 2022
@RaisinTen @targos
src: register StreamBase while registering LibuvStreamWrap
b045893 
This resolves this TODO -
https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43321
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RaisinTen @targos
src: register StreamBase while registering LibuvStreamWrap
bf553fd 
This resolves this TODO -
https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43321
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RaisinTen @guangwong
src: register StreamBase while registering LibuvStreamWrap
64e371c 
This resolves this TODO -
https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: nodejs/node#43321
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RaisinTen @nodejs-github-bot @jasnell @santigimeno @tniessen @joyeecheung @aduh95