Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: promote Chrome Dev Tool to tier 3 (diagnostic tooling support tiers) #43290

Merged
merged 1 commit into from
Jun 3, 2022
Merged

doc: promote Chrome Dev Tool to tier 3 (diagnostic tooling support tiers) #43290

merged 1 commit into from
Jun 3, 2022

Conversation

tony-go
Copy link
Member

@tony-go tony-go commented Jun 1, 2022

Hey node family 👋

Context

The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.

Updated

In the previous instance, we examined the case of the Chrome dev tool: issue link.

Even if we didn't have a proper testing strategy for this tool, the community widely uses it. So then, we thought that tier 3 was more appropriate.

Discuss

Feel free to share your thoughts, especially regarding testing 🧪 .

With love ❤️

cc @nodejs/diagnostics

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 1, 2022
RafaelGSS
RafaelGSS approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Fast-track has been requested by @lpinca. Please 👍 to approve.

mcollina
mcollina approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2022
@nodejs-github-bot nodejs-github-bot merged commit ac27c58 into nodejs:master Jun 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ac27c58

italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
@tony-go @italojs
doc: promote cdt to tier 3
4d1d464 
PR-URL: nodejs#43290
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@tony-go @danielleadams
doc: promote cdt to tier 3
869d7a9 
PR-URL: #43290
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@tony-go @danielleadams
doc: promote cdt to tier 3
fff0560 
PR-URL: #43290
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 28, 2022
Closed
targos pushed a commit that referenced this pull request Jul 12, 2022
@tony-go @targos
doc: promote cdt to tier 3
c359d7c 
PR-URL: #43290
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tony-go @targos
doc: promote cdt to tier 3
2f83110 
PR-URL: #43290
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tony-go @guangwong
doc: promote cdt to tier 3
9a541f2 
PR-URL: nodejs/node#43290
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@Flarna Flarna Flarna approved these changes

@marsonya marsonya marsonya approved these changes

@legendecas legendecas legendecas approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tony-go @nodejs-github-bot @mcollina @lpinca @gireeshpunathil @legendecas @marsonya @Flarna @RafaelGSS @RaisinTen