From 33edc9b1fab4356115c580cd38cae27a06829961 Mon Sep 17 00:00:00 2001 From: yaya Date: Sun, 10 Apr 2022 08:46:51 +0800 Subject: [PATCH 1/4] doc: improved parallel specification --- doc/contributing/building-node-with-ninja.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/contributing/building-node-with-ninja.md b/doc/contributing/building-node-with-ninja.md index 5231b73a8cdd6e..fdb4d73cf48a6f 100644 --- a/doc/contributing/building-node-with-ninja.md +++ b/doc/contributing/building-node-with-ninja.md @@ -22,14 +22,14 @@ ninja: Entering directory `out/Release` The bottom line will change while building, showing the progress as `[finished/total]` build steps. This is useful output that `make` does not -produce and is one of the benefits of using Ninja. Also, Ninja will likely -compile much faster than even `make -j4` (or -`-j`). You can still pass the -number of processes to run for [Ninja][] using the environment variable `JOBS`. -This will be the equivalent to the `-j` parameter in the regular `make`: +produce and is one of the benefits of using Ninja. When using Ninja builds +are always run in parallel, based by default on the number of CPUs your +system has, you can also use the `-j` parameter if you don't want to use +all the CPU. This will be the equivalent to the `-j` parameter in the +regular `make`: ```bash -JOBS=12 make +make -j [number] ``` ## Producing a debug build From bd557745a1874813c1f20a42b885e9a26aa709ea Mon Sep 17 00:00:00 2001 From: mawaregetsuka <33221990+mawaregetsuka@users.noreply.github.com> Date: Sun, 10 Apr 2022 22:36:44 +0800 Subject: [PATCH 2/4] Update doc/contributing/building-node-with-ninja.md Co-authored-by: mscdex --- doc/contributing/building-node-with-ninja.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/building-node-with-ninja.md b/doc/contributing/building-node-with-ninja.md index fdb4d73cf48a6f..f58ebb475cfd88 100644 --- a/doc/contributing/building-node-with-ninja.md +++ b/doc/contributing/building-node-with-ninja.md @@ -22,7 +22,7 @@ ninja: Entering directory `out/Release` The bottom line will change while building, showing the progress as `[finished/total]` build steps. This is useful output that `make` does not -produce and is one of the benefits of using Ninja. When using Ninja builds +produce and is one of the benefits of using Ninja. When using Ninja, builds are always run in parallel, based by default on the number of CPUs your system has, you can also use the `-j` parameter if you don't want to use all the CPU. This will be the equivalent to the `-j` parameter in the From 43e04af2baea01900f778c9d457f65e1395ecb32 Mon Sep 17 00:00:00 2001 From: mawaregetsuka <33221990+mawaregetsuka@users.noreply.github.com> Date: Sun, 10 Apr 2022 22:37:02 +0800 Subject: [PATCH 3/4] Update doc/contributing/building-node-with-ninja.md Co-authored-by: mscdex --- doc/contributing/building-node-with-ninja.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/contributing/building-node-with-ninja.md b/doc/contributing/building-node-with-ninja.md index f58ebb475cfd88..c778a9a19974f2 100644 --- a/doc/contributing/building-node-with-ninja.md +++ b/doc/contributing/building-node-with-ninja.md @@ -24,9 +24,8 @@ The bottom line will change while building, showing the progress as `[finished/total]` build steps. This is useful output that `make` does not produce and is one of the benefits of using Ninja. When using Ninja, builds are always run in parallel, based by default on the number of CPUs your -system has, you can also use the `-j` parameter if you don't want to use -all the CPU. This will be the equivalent to the `-j` parameter in the -regular `make`: +system has. You can use the `-j` parameter to override this behavior, +which is equivalent to the `-j` parameter in the regular `make`: ```bash make -j [number] From d2aee219834eb079284a99147daf829018391397 Mon Sep 17 00:00:00 2001 From: mawaregetsuka <33221990+mawaregetsuka@users.noreply.github.com> Date: Sun, 22 May 2022 17:34:50 +0800 Subject: [PATCH 4/4] Update doc/contributing/building-node-with-ninja.md Co-authored-by: Antoine du Hamel --- doc/contributing/building-node-with-ninja.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/contributing/building-node-with-ninja.md b/doc/contributing/building-node-with-ninja.md index c778a9a19974f2..8aae340e227034 100644 --- a/doc/contributing/building-node-with-ninja.md +++ b/doc/contributing/building-node-with-ninja.md @@ -28,7 +28,8 @@ system has. You can use the `-j` parameter to override this behavior, which is equivalent to the `-j` parameter in the regular `make`: ```bash -make -j [number] +make -j4 # With this flag, Ninja will limit itself to 4 parallel jobs, + # regardless of the number of cores on the current machine. ``` ## Producing a debug build