Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: throw invalid this on detached accessors #39752

Closed
wants to merge 1 commit into from
Closed

url: throw invalid this on detached accessors #39752

wants to merge 1 commit into from

Commits on Aug 12, 2021

  1. url: throw invalid this on detached accessors 

    Previously, using Reflect.get/set or calling a member
method like toString() detached from the instance would
result in an obscure internal error. This adds a proper
brand check and throws `ERR_INVALID_THIS` when appropriate.

Signed-off-by: James M Snell <[email protected]>
    @jasnell
    jasnell committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    01ce7d8 View commit details
    Browse the repository at this point in the history