Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: exclude gyp from markdown link checker #35423

Closed
wants to merge 1 commit into from
Closed

tools: exclude gyp from markdown link checker #35423

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 30, 2020

The changelog format used in gyp-next does not comply to the rules.

@targos
tools: exclude gyp from markdown link checker
44a25e7 
The changelog format used in gyp-next does not comply to the rules.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 30, 2020
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 30, 2020
@targos
Copy link
Member Author

targos commented Sep 30, 2020

Please 👍 to fast-track. This blocks #32698 which blocks V8 updates.

ryzokuken
ryzokuken approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 for fast-forwarding.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@targos targos mentioned this pull request Sep 30, 2020
Closed
4 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33295/

@aduh95
Copy link
Contributor

aduh95 commented Sep 30, 2020

Another way of doing it would be order references in ASCII order on the GYP CHANGELOG.

@aduh95 aduh95 mentioned this pull request Sep 30, 2020
Closed
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33296/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33297/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2020
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 30, 2020
@richardlau richardlau mentioned this pull request Sep 30, 2020
Open
14 tasks
addaleax pushed a commit that referenced this pull request Sep 30, 2020
@targos @addaleax
tools: exclude gyp from markdown link checker
a77f2ea 
The changelog format used in gyp-next does not comply to the rules.

PR-URL: #35423
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@addaleax
Copy link
Member

Landed in a77f2ea

@addaleax addaleax closed this Sep 30, 2020
@targos targos deleted the exclude-gyp-md branch September 30, 2020 15:57
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@targos @danielleadams
tools: exclude gyp from markdown link checker
a4e5a3a 
The changelog format used in gyp-next does not comply to the rules.

PR-URL: #35423
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@targos @MylesBorins
tools: exclude gyp from markdown link checker
e92e2ed 
The changelog format used in gyp-next does not comply to the rules.

PR-URL: #35423
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@targos @MylesBorins
tools: exclude gyp from markdown link checker
ae14923 
The changelog format used in gyp-next does not comply to the rules.

PR-URL: #35423
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
tools: exclude gyp from markdown link checker
6a7feef 
The changelog format used in gyp-next does not comply to the rules.

PR-URL: nodejs#35423
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @aduh95 @addaleax @gengjiawen @richardlau @ryzokuken