From 189677f9bf34cf5f0709db0e22fa1fac2b8d3b71 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 24 Sep 2020 17:42:18 +0200 Subject: [PATCH] url: warn when operation requires ICU --- src/node_url.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/node_url.cc b/src/node_url.cc index b7aeb8b006284f..d83109f3106cf9 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -787,11 +787,13 @@ bool ToASCII(const std::string& input, std::string* output) { #else // Intentional non-ops if ICU is not present. bool ToUnicode(const std::string& input, std::string* output) { + std::cerr << "Warning: Cannot convert to unicode when intl is disabled!\n"; *output = input; return true; } bool ToASCII(const std::string& input, std::string* output) { + std::cerr << "Warning: Cannot convert to ASCII when intl is disabled!\n"; *output = input; return true; }