Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: destroy only when both readable and writable finished #32216

Closed
wants to merge 1 commit into from
Closed

zlib: destroy only when both readable and writable finished #32216

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 11, 2020

Related to #32215

A zlib stream should not be destroyed until both sides has completed. Since 'end' can be emitted before 'finish'.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag added stream Issues and PRs related to the stream subsystem. zlib Issues and PRs related to the zlib subsystem. labels Mar 11, 2020
@ronag ronag requested a review from addaleax March 11, 2020 22:20
@ronag ronag mentioned this pull request Mar 11, 2020
Closed
@ronag ronag force-pushed the zlib-auto-destroy branch from 6cf1ace to 1a769bc Compare March 11, 2020 22:29
@ronag
Copy link
Member Author

ronag commented Mar 12, 2020

Close in favor of #32220

@ronag ronag closed this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ronag