From a284117394c8cf847e13649ec2a187bedd150f13 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sat, 14 Dec 2019 20:47:01 +0100
Subject: [PATCH 1/6] doc: add note about fs.close undefined behavior

---
 doc/api/fs.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 643efaae03395d..41467e9089b3d7 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -1533,6 +1533,9 @@ changes:
 Asynchronous close(2). No arguments other than a possible exception are given
 to the completion callback.
 
+Calling `fs.close` on any file descriptor (`fd`) that is currently in use
+through `fs.read`, `fs.write` or `fs.writev` may lead to undefined behavior.
+
 ## fs.closeSync(fd)
 <!-- YAML
 added: v0.1.21

From fe0142f76c7a524a0515dca97c2f776c5eeddd2e Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sat, 14 Dec 2019 20:50:40 +0100
Subject: [PATCH 2/6] fixup: any fs op

---
 doc/api/fs.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 41467e9089b3d7..32c30e16015e3c 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -1534,7 +1534,7 @@ Asynchronous close(2). No arguments other than a possible exception are given
 to the completion callback.
 
 Calling `fs.close` on any file descriptor (`fd`) that is currently in use
-through `fs.read`, `fs.write` or `fs.writev` may lead to undefined behavior.
+though any other `fs` operation may lead to undefined behavior.
 
 ## fs.closeSync(fd)
 <!-- YAML

From bc751b30de3f5d084fba3156da31c2177095e215 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 15 Dec 2019 01:22:45 +0100
Subject: [PATCH 3/6] Update doc/api/fs.md

Co-Authored-By: Rich Trott <rtrott@gmail.com>
---
 doc/api/fs.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 32c30e16015e3c..4f22e38f6b32a3 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -1533,7 +1533,7 @@ changes:
 Asynchronous close(2). No arguments other than a possible exception are given
 to the completion callback.
 
-Calling `fs.close` on any file descriptor (`fd`) that is currently in use
+Calling `fs.close()` on any file descriptor (`fd`) that is currently in use
 though any other `fs` operation may lead to undefined behavior.
 
 ## fs.closeSync(fd)

From 6fa8257a009418590b2d25485eadea20dddd8b63 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 15 Dec 2019 01:22:53 +0100
Subject: [PATCH 4/6] Update doc/api/fs.md

Co-Authored-By: Rich Trott <rtrott@gmail.com>
---
 doc/api/fs.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 4f22e38f6b32a3..366336583d019d 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -1534,7 +1534,7 @@ Asynchronous close(2). No arguments other than a possible exception are given
 to the completion callback.
 
 Calling `fs.close()` on any file descriptor (`fd`) that is currently in use
-though any other `fs` operation may lead to undefined behavior.
+through any other `fs` operation may lead to undefined behavior.
 
 ## fs.closeSync(fd)
 <!-- YAML

From cc5360906912d48a6cf20170923b1f111299f664 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 15 Dec 2019 01:23:57 +0100
Subject: [PATCH 5/6] fixup: add note to closeSync as well

---
 doc/api/fs.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 366336583d019d..22a4b85643a5e2 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -1545,6 +1545,9 @@ added: v0.1.21
 
 Synchronous close(2). Returns `undefined`.
 
+Calling `fs.closeSync` on any file descriptor (`fd`) that is currently in use
+though any other `fs` operation may lead to undefined behavior.
+
 ## fs.constants
 
 * {Object}

From c66cce862e7dfda5c793aa8b0ebac027b9f58617 Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Sun, 15 Dec 2019 23:31:59 +0100
Subject: [PATCH 6/6] Apply suggestions from code review

---
 doc/api/fs.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 22a4b85643a5e2..a6372f3b115337 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -1545,8 +1545,8 @@ added: v0.1.21
 
 Synchronous close(2). Returns `undefined`.
 
-Calling `fs.closeSync` on any file descriptor (`fd`) that is currently in use
-though any other `fs` operation may lead to undefined behavior.
+Calling `fs.closeSync()` on any file descriptor (`fd`) that is currently in use
+through any other `fs` operation may lead to undefined behavior.
 
 ## fs.constants