Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move Forrest Norvell to Collaborator Emeriti list #27437

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 27, 2019

Consulted with Forrest. He thought this was appropriate as long as it
doesn't affect his ability to be on the Moderation Team.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Consulted with Forrest. He thought this was appropriate as long as it
doesn't affect his ability to be on the Moderation Team.
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 27, 2019
@Trott Trott requested a review from othiym23 April 27, 2019 01:43
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2019
Copy link
Contributor

@othiym23 othiym23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being a diligent steward of the process, @Trott! Maybe I'll return to actively contributing in the future!

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@othiym23 thanks for all your work!

@danbev
Copy link
Contributor

danbev commented Apr 30, 2019

Landed in d33fddb.

@danbev danbev closed this Apr 30, 2019
danbev pushed a commit that referenced this pull request Apr 30, 2019
Consulted with Forrest. He thought this was appropriate as long as it
doesn't affect his ability to be on the Moderation Team.

PR-URL: #27437
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Forrest L Norvell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2019
Consulted with Forrest. He thought this was appropriate as long as it
doesn't affect his ability to be on the Moderation Team.

PR-URL: #27437
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Forrest L Norvell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@benjamingr
Copy link
Member

@Trott @danbev note that this landed but the actual GitHub team needs to be updated to reflect this change.

@Trott
Copy link
Member Author

Trott commented Apr 30, 2019

@Trott @danbev note that this landed but the actual GitHub team needs to be updated to reflect this change.

Yes, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants