Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: extract start and end check into checkPosition #25264

Closed
wants to merge 1 commit into from
Closed

fs: extract start and end check into checkPosition #25264

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 29, 2018

this.start and this.end in ReadStream meet the same conditions, extract their check into checkPosition function.

Maybe we can use it to check this.start in WriteStream too(but may need to do other works).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Dec 29, 2018
@addaleax
Copy link
Member

addaleax commented Jan 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/19985/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2019
@addaleax
Copy link
Member

addaleax commented Jan 9, 2019

Landed in 98ed23c

@addaleax addaleax closed this Jan 9, 2019
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@ZYSzys @addaleax
fs: extract start and end check into checkPosition
98ed23c 
PR-URL: #25264
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@ZYSzys @addaleax
fs: extract start and end check into checkPosition
ca7adca 
PR-URL: #25264
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@ZYSzys @BridgeAR
fs: extract start and end check into checkPosition
5c695cd 
PR-URL: nodejs#25264
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ZYSzys ZYSzys deleted the fs-internal-streams branch January 18, 2019 18:03
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZYSzys @addaleax @lpinca @starkwang @nodejs-github-bot