Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: introduce DCHECK macro and use DCHECK* macros where possible #25207

Merged
merged 2 commits into from
Dec 26, 2018
Merged

src: introduce DCHECK macro and use DCHECK* macros where possible #25207

merged 2 commits into from
Dec 26, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2059/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 24, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19814/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2018
@Trott
Copy link
Member

Trott commented Dec 26, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19821/

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 26, 2018

CI had one failure (#21451) and will be fixed by #25226.

@cjihrig
src: use DCHECK_* macros where possible
c2b4269 
PR-URL: nodejs#25207
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig
src: introduce DCHECK macro
4e31a7f 
This commit adds a DCHECK macro for consistency with the
other DCHECK_* macros.

PR-URL: nodejs#25207
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig cjihrig merged commit 4e31a7f into nodejs:master Dec 26, 2018
@cjihrig cjihrig deleted the check branch December 26, 2018 17:28
@cjihrig cjihrig mentioned this pull request Dec 26, 2018
Closed
2 tasks
targos pushed a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
src: use DCHECK_* macros where possible
e2a01ca 
PR-URL: #25207
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
src: introduce DCHECK macro
99a5af6 
This commit adds a DCHECK macro for consistency with the
other DCHECK_* macros.

PR-URL: #25207
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
src: use DCHECK_* macros where possible
26a507e 
PR-URL: nodejs#25207
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
src: introduce DCHECK macro
b899aee 
This commit adds a DCHECK macro for consistency with the
other DCHECK_* macros.

PR-URL: nodejs#25207
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @nodejs-github-bot @addaleax @Trott @lpinca @targos @tniessen @BridgeAR @BethGriggs