Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls,net: fix shutdown issue more cleanly #24290

Closed
wants to merge 3 commits into from
Closed

tls,net: fix shutdown issue more cleanly #24290

wants to merge 3 commits into from

Commits on Nov 10, 2018

  1. tls: do not rely on 'drain' handlers in StreamWrap 

    `'drain'` event handlers may not be invoked if the stream
is currently finishing. Instead, use the fact that we know
when writes are active or not, and invoke the delayed shutdown
handler from our own after-write callback.
    @addaleax
    addaleax committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    fbac8e8 View commit details
    Browse the repository at this point in the history

  2. tls: destroy TLS socket if StreamWrap is destroyed 

    Previously, there was no mechanism in place that would
have destroyed the TLS socket once the underlying socket
had been closed.
    @addaleax
    addaleax committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    c58bced View commit details
    Browse the repository at this point in the history

  3. Revert "net: partially revert "simplify Socket.prototype._final"" 

    This reverts commit ac1f56c.

Refs: nodejs#24288
Refs: nodejs#24075
    @addaleax
    addaleax committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    4cae5b8 View commit details
    Browse the repository at this point in the history