-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove function hasTextDecoder in encoding.js #23625
src: remove function hasTextDecoder in encoding.js #23625
Conversation
encoding.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Can we also get rid of |
@mscdex It appears that It appears we can return the constructor directly from both TextDecoder factories. I'll make the change. |
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17805 |
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17817/ |
Re-run of failing node-test-commit-linux |
The Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17887/ |
@Trott Thanks! There still appears to be one failure in the run. Let me know if I can do anything to help resolve the CI failures (like rebase the branch against master). |
Getting this landed. |
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Landed in 25dc25b |
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Remove
hasTextDecoder
in/lib/internal/encoding.js
.hasTextDecoder
is unused. This has the benefit of increasing test coverage.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes