-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update node-lint-md-cli-rollup #23358
Conversation
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2).
I vendored it in to reduce the turnaround time on updates to rules (if the files are checked in we can update the rules independently of |
But don't you want to run it ( |
BTW: we don't (yet) have a regression test for the tool. I tested it manually, but that might be a nice chore... |
Just an observation (not blocking this) but this undoes parts of #23302 (13340d4#diff-e511e27e1719c62f08ee48fd97573087). It's not particularly obvious that |
We could add a preamble to the file... Or Uglify it... Again some interesting chores... |
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: nodejs#23358 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Landed in 54ce229 |
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with
npm audit
. It also updates remark-preset-lint-node to1.0.3 (from 1.0.2).
@refack This removes the md lint preset stuff from the filesystem and relies on the npm registry. Having it on the file system messed with
npm update
andnpm audit fix
and othernpm
commands I ran trying to work around it. If you'd like to keep it in the repo, I'm happy to restore it that way. This seems simpler to me and (based on thenpm
issues I just described) more robust. But just give me a quick explanation why you want it the way it was, and I'll restore it!Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes