-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[x9.x backport] src: remove unused using declarations async_wrap #19253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#18893 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
v9.x
labels
Mar 9, 2018
node-test-commit failure looks unrelatedFATAL: java.io.IOException: Unexpected EOF while receiving the data from the channel. FIFO buffer has been already closed
org.jenkinsci.remoting.nio.FifoBuffer$CloseCause: Buffer close has been requested
at org.jenkinsci.remoting.nio.FifoBuffer.close(FifoBuffer.java:426)
at org.jenkinsci.remoting.nio.NioChannelHub$MonoNioTransport.closeR(NioChannelHub.java:338)
at org.jenkinsci.remoting.nio.NioChannelHub.run(NioChannelHub.java:571)
Caused: java.io.IOException: Unexpected EOF while receiving the data from the channel. FIFO buffer has been already closed
at org.jenkinsci.remoting.nio.NioChannelHub$3.run(NioChannelHub.java:629)
Also: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Channel to /72.2.114.47
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.Request.call(Request.java:192)
at hudson.remoting.Channel.call(Channel.java:907)
at hudson.Launcher$RemoteLauncher.kill(Launcher.java:1079)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:510)
at hudson.model.Run.execute(Run.java:1724)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused: hudson.remoting.RequestAbortedException
at hudson.remoting.Request.abort(Request.java:329)
at hudson.remoting.Channel.terminate(Channel.java:992)
at org.jenkinsci.remoting.nio.NioChannelHub$3.run(NioChannelHub.java:628)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[Current build status] check if current [FAILURE] is worse or equals then [UNSTABLE] and better or equals then [SUCCESS]
Run condition [Current build status] preventing perform for step [[]]
ERROR: Step ?Publish TAP Results? failed: no workspace for node-test-commit-smartos/nodes=smartos14-64 #15945
Checking ^not ok
ERROR: Build step failed with exception
java.lang.NullPointerException
Build step 'Jenkins Text Finder' marked build as failure
Notifying upstream projects of job completion
Finished: FAILURE |
cjihrig
approved these changes
Mar 9, 2018
jasnell
approved these changes
Mar 9, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Backport-PR-URL: #19253 PR-URL: #18893 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
landed in 1ba1861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #18893
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Minwoo Jung [email protected]
Reviewed-By: Yuta Hiroto [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Ruben Bridgewater [email protected]
Reviewed-By: Gibson Fahnestock [email protected]
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes