diff --git a/test/fixtures/test-regress-GH-4015.js b/test/fixtures/test-fs-stat-sync-overflow.js similarity index 100% rename from test/fixtures/test-regress-GH-4015.js rename to test/fixtures/test-fs-stat-sync-overflow.js diff --git a/test/sequential/test-regress-GH-1726.js b/test/sequential/test-child-process-exit.js similarity index 98% rename from test/sequential/test-regress-GH-1726.js rename to test/sequential/test-child-process-exit.js index 1291dec261ccf6..303f015cf0aebd 100644 --- a/test/sequential/test-regress-GH-1726.js +++ b/test/sequential/test-child-process-exit.js @@ -20,12 +20,13 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; +require('../common'); + // Open a chain of five Node processes each a child of the next. The final -// process exits immediately. Each process in the chain is instructed to -// exit when its child exits. +// process exits immediately. Each process in the chain is instructed to exit +// when its child exits. // https://github.com/joyent/node/issues/1726 -require('../common'); const assert = require('assert'); const ch = require('child_process'); diff --git a/test/sequential/test-regress-GH-4015.js b/test/sequential/test-fs-stat-sync-overflow.js similarity index 76% rename from test/sequential/test-regress-GH-4015.js rename to test/sequential/test-fs-stat-sync-overflow.js index cac20c7948ae2f..9c9109989a19c3 100644 --- a/test/sequential/test-regress-GH-4015.js +++ b/test/sequential/test-fs-stat-sync-overflow.js @@ -22,11 +22,19 @@ 'use strict'; require('../common'); const { fixturesDir } = require('../common/fixtures'); + +// Check that the calls to Integer::New() and Date::New() succeed and bail out +// if they don't. +// V8 returns an empty handle on stack overflow. Trying to set the empty handle +// as a property on an object results in a NULL pointer dereference in release +// builds and an assert in debug builds. +// https://github.com/nodejs/node-v0.x-archive/issues/4015 + const assert = require('assert'); const { exec } = require('child_process'); const cmd = - `"${process.execPath}" "${fixturesDir}/test-regress-GH-4015.js"`; + `"${process.execPath}" "${fixturesDir}/test-fs-stat-sync-overflow.js"`; exec(cmd, function(err, stdout, stderr) { assert(/RangeError: Maximum call stack size exceeded/.test(stderr)); diff --git a/test/sequential/test-regress-GH-4027.js b/test/sequential/test-fs-watch-file-enoent-after-deletion.js similarity index 81% rename from test/sequential/test-regress-GH-4027.js rename to test/sequential/test-fs-watch-file-enoent-after-deletion.js index 8936537323581e..f5b9012acabe58 100644 --- a/test/sequential/test-regress-GH-4027.js +++ b/test/sequential/test-fs-watch-file-enoent-after-deletion.js @@ -21,6 +21,17 @@ 'use strict'; const common = require('../common'); + +// Make sure the deletion event gets reported in the following scenario: +// 1. Watch a file. +// 2. The initial stat() goes okay. +// 3. Something deletes the watched file. +// 4. The second stat() fails with ENOENT. + +// The second stat() translates into the first 'change' event but a logic error +// stopped it from getting emitted. +// https://github.com/nodejs/node-v0.x-archive/issues/4027 + const assert = require('assert'); const path = require('path'); const fs = require('fs'); diff --git a/test/sequential/test-regress-GH-784.js b/test/sequential/test-http-econnrefused.js similarity index 96% rename from test/sequential/test-regress-GH-784.js rename to test/sequential/test-http-econnrefused.js index 4b285020d45a35..ff4508963b9877 100644 --- a/test/sequential/test-regress-GH-784.js +++ b/test/sequential/test-http-econnrefused.js @@ -20,15 +20,15 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -// Regression test for GH-784 -// https://github.com/joyent/node/issues/784 -// +const common = require('../common'); + // The test works by making a total of 8 requests to the server. The first // two are made with the server off - they should come back as ECONNREFUSED. // The next two are made with server on - they should come back successful. // The next two are made with the server off - and so on. Without the fix -// we were experiencing parse errors and instead of ECONNREFUSED. -const common = require('../common'); +// we were experiencing parse errors instead of ECONNREFUSED. +// https://github.com/nodejs/node-v0.x-archive/issues/784 + const http = require('http'); const assert = require('assert'); diff --git a/test/sequential/test-regress-GH-877.js b/test/sequential/test-http-max-sockets.js similarity index 94% rename from test/sequential/test-regress-GH-877.js rename to test/sequential/test-http-max-sockets.js index c717c2dd74f444..24629448f7ac77 100644 --- a/test/sequential/test-regress-GH-877.js +++ b/test/sequential/test-http-max-sockets.js @@ -21,6 +21,10 @@ 'use strict'; const common = require('../common'); + +// Make sure http server doesn't wait for socket pool to establish connections +// https://github.com/nodejs/node-v0.x-archive/issues/877 + const http = require('http'); const assert = require('assert'); diff --git a/test/sequential/test-regress-GH-1697.js b/test/sequential/test-net-response-size.js similarity index 91% rename from test/sequential/test-regress-GH-1697.js rename to test/sequential/test-net-response-size.js index 9d2555705ab023..c5d7e9b600e05d 100644 --- a/test/sequential/test-regress-GH-1697.js +++ b/test/sequential/test-net-response-size.js @@ -21,6 +21,11 @@ 'use strict'; const common = require('../common'); + +// Make sure the net module's server doesn't throw an error when handling +// responses that are either too long or too small (especially on Windows) +// https://github.com/nodejs/node-v0.x-archive/issues/1697 + const net = require('net'); const cp = require('child_process');