Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: using internal/errors.js #15630

Closed
wants to merge 2 commits into from
Closed

https: using internal/errors.js #15630

wants to merge 2 commits into from

Conversation

clarenced
Copy link
Contributor

migrate lib/https.js to internal/errors.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

https

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. https Issues or PRs related to the https subsystem. labels Sep 26, 2017
@lpinca
Copy link
Member

lpinca commented Sep 27, 2017

Competing PR: #15603.

TheJaredWilcurt
TheJaredWilcurt reviewed Sep 27, 2017
View reviewed changes
doc/api/errors.md Outdated
@@ -1273,6 +1273,11 @@ entry types were found.

Used when a given value is out of the accepted range.

<a id="ERR_UNDEFINED_DOMAIN_NAME">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</a>

@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 28, 2017
@jasnell
Copy link
Member

jasnell commented Sep 28, 2017

Went ahead and pushed a commit to fix the doc nit.

Are there no tests that are impacted by this? Perhaps we should get one added.

jasnell
jasnell approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but thinking adding a test would be better.

@jasnell jasnell requested review from fhinkel and mhdawson September 28, 2017 12:45
@lpinca
Copy link
Member

lpinca commented Sep 28, 2017

As @BridgeAR pointed out in #15603 it would be better to use the existing ERR_INVALID_DOMAIN_NAME.

@BridgeAR
Copy link
Member

I am closing this as the other PR is already using the correct error type and was opened earlier.

@clarenced I am sorry your PR could not land. Your work is much appreciated nevertheless.

@BridgeAR BridgeAR closed this Sep 28, 2017
@clarenced
Copy link
Contributor Author

@BridgeAR That's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJaredWilcurt TheJaredWilcurt TheJaredWilcurt left review comments

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel Awaiting requested review from fhinkel

@mhdawson mhdawson Awaiting requested review from mhdawson

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. https Issues or PRs related to the https subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clarenced @lpinca @jasnell @BridgeAR @TheJaredWilcurt @nodejs-github-bot