Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-fs-read-buffer-to-string-fail as pass and flaky to all platforms #14495

Closed
wants to merge 4 commits into from
Closed

test: add test-fs-read-buffer-to-string-fail as pass and flaky to all platforms #14495

wants to merge 4 commits into from

Commits on Aug 1, 2017

  1. net: support passing undefined to listen() 

    For consistency with 4.x and 8.x.

This commit also contains a forward port of
nodejs#14232 to confirm that 4.x and 6.x
behave identically with respect to the port argument.

PR-URL: nodejs#14234
Refs: nodejs#14205
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
    @sam-github @MylesBorins
    sam-github authored and MylesBorins committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    b80aedf View commit details
    Browse the repository at this point in the history

  2. src: make root_cert_vector function scoped 

    root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.

PR-URL: nodejs#12788
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
    @danbev @MylesBorins
    danbev authored and MylesBorins committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    02e0b1a View commit details
    Browse the repository at this point in the history

  3. crypto: remove root_cert_store from node_crypto.h 

    root_cert_store is defined as extern in node_crypto.h but only used in
node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only
usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all
be accessing the same X509_STORE through the root_cert_store pointer as
far as I can tell. Am I missing something here?

This commit suggests removing it from the header and making it static
in node_crypto.cc.

PR-URL: nodejs#13194
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
    @danbev @MylesBorins
    danbev authored and MylesBorins committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    f4691bb View commit details
    Browse the repository at this point in the history

  4. test: mark test-fs-read-buffer-to-string-fail as flaky 

    PR-URL: nodejs#14495
Fixes: nodejs#14430
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @Jeyanthinath @refack
    Jeyanthinath authored and refack committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    0b012a6 View commit details
    Browse the repository at this point in the history