src: replace IsConstructCall functions with lamda #12384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Apr 13, 2017
src/cares_wrap.cc
Outdated
| @@ -1399,24 +1384,27 @@ static void Initialize(Local<Object> target, | |||
| target->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "AI_V4MAPPED"), | |||
| Integer::New(env->isolate(), AI_V4MAPPED)); | |||
|
|
|||
| auto isConstructCall = [](const FunctionCallbackInfo<Value>& args) { | |||
| CHECK(args.IsConstructCall()); | |||
There was a problem hiding this comment.
Only two spaces of indent and call the variable is_construct_call (or is_construct_call_callback to indicate it's a function pointer.)
There was a problem hiding this comment.
Ah again, must remember to not use camelcase 😞 Thanks!
danbev
force-pushed
the
cares_wrap-lamda
branch
from
3fc1684 to
ce11999
Compare
cjihrig
approved these changes
Apr 13, 2017
jasnell
approved these changes
Apr 13, 2017
I noticed that there are three static functions that only check if args is a construct call. This commit suggests replacing them and them with a lambda.
danbev
force-pushed
the
cares_wrap-lamda
branch
from
ce11999 to
a440ec8
Compare
addaleax
approved these changes
Apr 15, 2017
|
Landed in b280363 |
addaleax
pushed a commit
that referenced
this pull request
Apr 15, 2017
I noticed that there are three static functions that only check if args is a construct call. This commit suggests replacing them and them with a lambda. PR-URL: #12384 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
3 tasks
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lamda.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src