Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building on Windows x86 #12184

Closed
wants to merge 2 commits into from
Closed

Fix building on Windows x86 #12184

wants to merge 2 commits into from

Commits on Apr 10, 2017

  1. build,win: limit maxcpucount to 2 for MSBuild 

    MSBuild invokes cl.exe with /MP (set in common.gypi), making it
compile sources in parallel using a number of internal processes
equal to the number of effective processors. MSBuild /m uses a
similar mechanism, so the number of compiler processes can grow to
the number of effective processors squared.

This limits MSBuild to 2 processes, to still use some parallelization
while requiring less memory. Cl.exe is still invoked with /MP, thus
the maximum number of processes is limited to twice the number of
effective processors.

PR-URL: nodejs#12184
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
    @joaocgreis
    joaocgreis committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    6dd0f75 View commit details
    Browse the repository at this point in the history

  2. deps,win: increase msvs_shard in gyp for V8 

    Increase the number of shards to divide v8_base into. This increases
the number of calls to cl.exe but decreases the number of files
compiled each time.

Fixes: nodejs/v8#4
PR-URL: nodejs#12184
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
    @joaocgreis
    joaocgreis committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    d50bb93 View commit details
    Browse the repository at this point in the history