From ccb0c671fd4415681f0430e1ec9943690499bcf4 Mon Sep 17 00:00:00 2001 From: Howard Hellyer Date: Tue, 14 Feb 2017 14:14:05 +0000 Subject: [PATCH 1/2] test: Run test-setproctitle where supported Setting the process title has been enabled in libuv on AIX and z/OS. The latest level of libuv skips only skips testing of uv_set_process_title when __sun is #defined. This change simplifies the skip test so the test is only skipped when common.isSunOS is true to match libuv. --- test/parallel/test-setproctitle.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-setproctitle.js b/test/parallel/test-setproctitle.js index 9dd603bfdc3327..84c39aec7e8c65 100644 --- a/test/parallel/test-setproctitle.js +++ b/test/parallel/test-setproctitle.js @@ -3,7 +3,7 @@ const common = require('../common'); // FIXME add sunos support -if (!(common.isFreeBSD || common.isOSX || common.isLinux)) { +if (common.isSunOS) { console.log(`1..0 # Skipped: Unsupported platform [${process.platform}]`); return; } From 777f516b091e53054be0fb7bfd02e5dfe118bc45 Mon Sep 17 00:00:00 2001 From: Howard Hellyer Date: Fri, 17 Feb 2017 16:02:33 +0000 Subject: [PATCH 2/2] test: Run test-setproctitle where supported Skip running the `ps` part of the test on Windows. --- test/parallel/test-setproctitle.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/parallel/test-setproctitle.js b/test/parallel/test-setproctitle.js index 84c39aec7e8c65..a971d604b37d14 100644 --- a/test/parallel/test-setproctitle.js +++ b/test/parallel/test-setproctitle.js @@ -21,6 +21,10 @@ assert.notStrictEqual(process.title, title); process.title = title; assert.strictEqual(process.title, title); +// Test setting the title but do not try to run `ps` on Windows. +if (common.isWindows) + return; + exec(`ps -p ${process.pid} -o args=`, function callback(error, stdout, stderr) { assert.ifError(error); assert.strictEqual(stderr, '');