Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: install header files required for compiled addons #859

Closed
piscisaureus opened this issue Feb 16, 2015 · 11 comments
Closed

windows: install header files required for compiled addons #859

piscisaureus opened this issue Feb 16, 2015 · 11 comments
Labels
feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors. install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.

Comments

@piscisaureus
Copy link
Contributor

The windows installer should install header files. If we do this node-gyp wouldn't have to download a tarball to get the headers.
I would suggest to install them into program files\iojs\include.

@sam-github
Copy link
Contributor

+ a bunch, needing proxy access to external internet in order to just compile a c++ addon is onerous.

@mscdex
Copy link
Contributor

mscdex commented Feb 16, 2015

+1

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Feb 16, 2015

👍

@piscisaureus piscisaureus added windows Issues and PRs related to the Windows platform. enhancement install Issues and PRs related to the installers. labels Feb 17, 2015
@piscisaureus
Copy link
Contributor Author

I can do it myself, but this is also a reasonably simple patch that can be implemented by another contributor.

@Fishrock123 Fishrock123 added the good first issue Issues that are suitable for first-time contributors. label Aug 27, 2015
@Trott
Copy link
Member

Trott commented Mar 28, 2016

Forgive me if this is a naïve question, but does this basically involve opening tools/msvs/msi in Visual Studio and adding the header files there?

@Fishrock123 Fishrock123 added the feature request Issues that request new features to be added to Node.js. label Aug 3, 2016
@Trott
Copy link
Member

Trott commented Jul 9, 2017

@piscisaureus @nodejs/build Should this remain open?

@gibfahn
Copy link
Member

gibfahn commented Jul 9, 2017

I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer.

@Trott
Copy link
Member

Trott commented Jul 9, 2017

I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer.

OK, closing, but feel free to re-open etc. etc. etc.

@Trott Trott closed this as completed Jul 9, 2017
@refack
Copy link
Contributor

refack commented Jul 10, 2017

I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer.

OK, closing, but feel free to re-open etc. etc. etc.

but the "embed the headers in the binary" should be a node core issue...

@bnoordhuis
Copy link
Member

I have it in my backlog.

@refack
Copy link
Contributor

refack commented Jul 10, 2017

I have it in my backlog.

Some of this conversation must have leaked into my subconscious, since two ideas came to me in a dream last night:

  1. embed a zip file into the node binary, extract with 3rd party tool (7zip can find embedded archives)
  2. add to the JS snapshot as a MMM.writeHeaderFiles(path)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors. install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

10 participants