Windows MSI installer broken

[ineeee]

Windows installer for io.js version 1.2.0 (iojs-v1.2.0-x86.msi) is broken. Sometimes. Four out of five times. Yay.

I tried installing 4 times and it didn't work:

BUT the 5th time, it did work: http://puu.sh/fT7wz.webm

Its confusing. I don't know what causes the error.

[mathiask88]

Can you run the installer with msiexec /i iojs-v1.2.0-x86.msi /l*v InstallLog.txt from cmd and gist the content if the error occurred?

[piscisaureus]

It looks like creating the hard link failed. Was node.exe present in c:\dev\iojs and running?

[ineeee]

Wow did it really take me this long to reply

Running msiexec /i iojs-v1.2.0-x64.msi /L*V installation.log and generating the expected error...

Returned this massive 14 MiB error log (that I had to compress because I have bad internet): http://puu.sh/gv6Js.zip

[mathiask88]

Better late than never! 😉

MSI (s) (58:A4) [20:02:07:510]: Executing op: ActionStart(Name=LinkNodeExeToIojsExe,,)
Action 20:02:07: LinkNodeExeToIojsExe. 
MSI (s) (58:A4) [20:02:07:510]: Executing op: CustomActionSchedule(Action=LinkNodeExeToIojsExe,ActionType=3090,Source=D:\dev\iojs\iojs.exe,Target=-e " require('fs').linkSync(process.execPath, require('path').resolve(process.execPath, '../node.exe')); ",)
CustomAction LinkNodeExeToIojsExe returned actual error code 1 (note this may not be 100% accurate if translation happened inside sandbox)
MSI (s) (58:A4) [20:02:08:137]: Note: 1: 1722 2: LinkNodeExeToIojsExe 3: D:\dev\iojs\iojs.exe 4: -e " require('fs').linkSync(process.execPath, require('path').resolve(process.execPath, '../node.exe')); " 
Error 1722. There is a problem with this Windows Installer package. A program run as part of the setup did not finish as expected. Contact your support personnel or package vendor.  Action LinkNodeExeToIojsExe, location: D:\dev\iojs\iojs.exe, command: -e " require('fs').linkSync(process.execPath, require('path').resolve(process.execPath, '../node.exe')); " 
MSI (s) (58:A4) [20:03:28:448]: Product: io.js -- Error 1722. There is a problem with this Windows Installer package. A program run as part of the setup did not finish as expected. Contact your support personnel or package vendor.  Action LinkNodeExeToIojsExe, location: D:\dev\iojs\iojs.exe, command: -e " require('fs').linkSync(process.execPath, require('path').resolve(process.execPath, '../node.exe')); " 

This is the position where the error occurs and @piscisaureus was right. So can you look if node.exe is present in D:\dev\iojs while the error dialogue is displayed?

[ineeee]

Why is node.exe needed? At this point you guys should just keep iojs.exe

The D:\dev\iojs folder is there with all the files but node.exe:

[mathiask88]

node.exeis a hardlink to iojs.exe and is needed for node.js compatibility, in short that you can use the node shortcut in cmd. If the returned error code (ERROR_INVALID_FUNCTION) is right this is usually because the fs does not support hardlinks. Is D:\ a local NTFS hard drive?

[ineeee]

Iojs team should look into making a node.cmd file with iojs %* and forget about it.
Yes, of course D:\ is a NTFS drive (the 5th time I ran the installer it worked, duh).

[piscisaureus]

The problem with a .cmd files are:

• arguments cannot be forwarded exactly
• spawn() can't run cmd files

[Fishrock123]

I think this is probably related to #751

Closing since the issue is stale and this won't be an issue in the converged node?