-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encountering segfault #6604
Comments
@tylersmalley are you still getting the same issues on v4.4.3? |
It can be a bug in native addon, which frees buffer owned by ArrayBuffer |
@thealphanerd, we have encountered different issues when running on 4.4.3 as our memory usage for the application almost doubles (TLS related). I am working to resolves those and will test. @mscdex, #6301 appears to be the same issue. The application is running with |
@tylersmalley I'd love to hear more about the usage problems... specifically if it involves something we landed that could be reverted. v4.4.4 is about to drop and will be coming with the latest openssl updates, which you will likely want |
+1 on addressing this ticket (and/or #6301). Seeing the node process crash in production every week is concerning. |
@tylersmalley @ppf2 Is it possible you could test with node v6.1.0 and let us know if you still encounter the segfault there? Assuming this is a v8 issue, that might help to narrow it down a little bit. |
@mscdex, I am working to get out app to run on v6.1.0 - but currently it does not. This is primarily due to |
@tylersmalley Anything to report? If not, can we close this issue? |
Hey @bnoordhuis, we just recently were able to push forward with the changes required to migrate to Node 6 and is my current focus. We should be able to begin testing next week. |
@bnoordhuis - Bumping to Node 6.3 resolved this issue for us. |
Thanks for the update, I'll close out the issue. If anyone has ideas on how to reproduce (or better yet: fix) the issue, please shout. |
We are also getting a segfault with large values of We use This would work fine with Node v0.10.45 but segfaults with Node v7.0.0 and interim versions. I noticed your integer overflow fix to V8's
Could this have something to do with it? Or is there still an integer overflow somewhere else? Is |
Here is a very small script to reproduce it: https://gist.github.com/jorangreef/ccf6f4dabc87caa1889dbf2fca2df031 We are running with a modified Running with this modified node and using Could it be something to do with incremental GC now being more involved and perhaps a double-free, where this would not usually happen if the |
That may have been fine four years ago but it sounds like a recipe for disaster with the current garbage collector. If you run into issues with an unpatched node binary, I'm happy to look into them. |
We're encountering a segfault when running our application:
kernel: [1500729.221978] node[10053]: segfault at 3f7137666df8 ip 0000000000bcebae sp 00007ffc90283310 error 4 in node[400000+1347000]
This crash randomly occurs every couple days. Not sure if this is associated with the GC or JSON Parser.
And inspecting the core dump:
The text was updated successfully, but these errors were encountered: