Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.watch filename incorrect #6163

Closed
zachary822 opened this issue Apr 12, 2016 · 1 comment
Closed

fs.watch filename incorrect #6163

zachary822 opened this issue Apr 12, 2016 · 1 comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. fs Issues and PRs related to the fs subsystem / file system.

Comments

@zachary822
Copy link

  • Version: v5.10.1
  • Platform: Linux localhost.localdomain 3.10.0-327.el7.x86_64 deps: update openssl to 1.0.1j #1 SMP Thu Nov 19 22:10:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
  • Subsystem: fs

The file names that the fs.watch function reports is different from fs.readdirSync when the file names have Chinese characters, with the fs.readdirSync file names being correct. Buffer.from(badFileNameFromFsWatch, 'binary').toString('utf-8') will produce the correct file name, consistent with fs.readdirSync.
@bnoordhuis
Copy link
Member

That's been fixed in #5616 (see also: #2088 and #3519) and will be released in v6. I'll close, the changes constitute a semver-major change and won't be back-ported to v4 and v5.

@bnoordhuis bnoordhuis added duplicate Issues and PRs that are duplicates of other issues or PRs. fs Issues and PRs related to the fs subsystem / file system. labels Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnoordhuis @zachary822