Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Debug build broken? #55900

Closed
juanarbol opened this issue Nov 17, 2024 · 4 comments
Closed

Is Debug build broken? #55900

juanarbol opened this issue Nov 17, 2024 · 4 comments
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Comments

@juanarbol
Copy link
Member

Version

main branch

Platform

Darwin Juans-MacBook-Pro.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:21:53 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6020 arm64

Subsystem

No response

What steps will reproduce the bug?

./configure --debug
make -j32

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

It should build

What do you see instead?

Undefined symbols for architecture arm64:
  "std::__1::enable_if<std::is_integral_v<long> && std::is_signed_v<long>, bool>::type v8::internal::Smi::IsValid<long>(long)", referenced from:
      v8::internal::Isolate::GetOrRegisterRecorderContextId(v8::internal::Handle<v8::internal::NativeContext>) in libv8_base_without_compiler.a(isolate.o)
      v8::internal::interpreter::Interpreter::GetDispatchCountersObject() in libv8_base_without_compiler.a(interpreter.o)
      v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedSmiElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)0>>::CollectElementIndices(v8::internal::Handle<v8::internal::JSObject>, v8::internal::Handle<v8::internal::FixedArrayBase>, v8::internal::KeyAccumulator*) in libv8_base_without_compiler.a(elements.o)
      v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedSmiElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)0>>::PrependElementIndices(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSObject>, v8::internal::Handle<v8::internal::FixedArrayBase>, v8::internal::Handle<v8::internal::FixedArray>, v8::internal::GetKeysConversion, v8::internal::PropertyFilter) in libv8_base_without_compiler.a(elements.o)
      v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastHoleySmiElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)1>>::CollectElementIndices(v8::internal::Handle<v8::internal::JSObject>, v8::internal::Handle<v8::internal::FixedArrayBase>, v8::internal::KeyAccumulator*) in libv8_base_without_compiler.a(elements.o)
      v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastHoleySmiElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)1>>::PrependElementIndices(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSObject>, v8::internal::Handle<v8::internal::FixedArrayBase>, v8::internal::Handle<v8::internal::FixedArray>, v8::internal::GetKeysConversion, v8::internal::PropertyFilter) in libv8_base_without_compiler.a(elements.o)
      v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2>>::CollectElementIndices(v8::internal::Handle<v8::internal::JSObject>, v8::internal::Handle<v8::internal::FixedArrayBase>, v8::internal::KeyAccumulator*) in libv8_base_without_compiler.a(elements.o)
      ...
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [/Users/juanjose/GitHub/node/out/Debug/mksnapshot] Error 1
rm a609fd90b86a20fd460f420029e465ae51d4bf1b.intermediate fa9e31ba0cf5879b4ace21ea5b8c43558c725cf7.intermediate fc563c17a924be76e355ae0a1f85d2a2506f67b7.intermediate
make: *** [node_g] Error 2

Additional information

My current HEAD is 1618463

I can build V8 standalone in my computer in debug mode.

@juanarbol juanarbol added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Nov 17, 2024
@juanarbol
Copy link
Member Author

cc @nodejs/build

@targos
Copy link
Member

targos commented Nov 18, 2024

What's your Xcode version? I can make debug builds without issues using version 16.1 (Apple Clang 16.0.0).

@juanarbol
Copy link
Member Author

I've Apple clang version 14.0.3

@juanarbol
Copy link
Member Author

After update to sequoia I can build on debug mode, sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

2 participants