Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove scroll up when highlighting text #53594

Closed
KostiantynO opened this issue Jun 26, 2024 · 7 comments
Closed

doc: remove scroll up when highlighting text #53594

KostiantynO opened this issue Jun 26, 2024 · 7 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@KostiantynO
Copy link

KostiantynO commented Jun 26, 2024

Affected URL(s)

https://nodejs.org/docs/latest/api/stream.html

Description of the problem

Hello!
I have experienced a bug with docs:
When I try to select a code snippet, the scrolling goes up very fast.

Highlight any text with mouse:

  • Hold down left mouse button
  • Start selecting text on the page
  • Move cursor above the 50% of the window height

Current result: it selects unwanted information above the highlighted part of text, because of excessive scrolling up.
Expected result: It only selects the highlighted text.

Selecting text in Node.js docs send scroll up to the moon

This decreases the usability of the docs significantly, because I can only read them, and cannot reliably copy any text I want to select.

Such problem does not exist in react docs.
But in node.js it does exist, and such inconsistency is unacceptable UX.

Suggesting: Node.js do have a very large pages. Maybe it will be better to split them into smaller sections for better usability.

System:
OS: Windows 10 Home 22H2 (OS build 19045.4529)
Browser: Chrome Version 126.0.6478.116 (Official Build) (64-bit)

@KostiantynO KostiantynO added the doc Issues and PRs related to the documentations. label Jun 26, 2024
@RedYetiDev RedYetiDev added the feature request Issues that request new features to be added to Node.js. label Jun 27, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Jun 27, 2024
@RedYetiDev RedYetiDev moved this from Awaiting Triage to Triaged in Node.js feature requests Jun 27, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Jun 27, 2024

@nodejs/documentation (The documentation team)
@ovflowd (Preparing a redesign
FWIW IIRC, React has a different page for each item, while Node.js has a different page for each subsystem. The two projects are documenting much different things.

@KostiantynO
Copy link
Author

I just want to select text on the page.
I have a very specific need for this.
Can it be done in node docs?
In react docs any page does not scroll up, while in node docs every page is bugged. I cannot select small portion of a text, because mouse goes to the sky like on provided gif.
I would try to help with this in spare time, if it can be done.

@RedYetiDev
Copy link
Member

I see the issue you are describing, but your issue is asking to split the docs like React. if you have an issue with the scrolling, please dedicate an issue directly to that.

@RedYetiDev
Copy link
Member

A fix for the behavior you described is underway

@RedYetiDev RedYetiDev removed the feature request Issues that request new features to be added to Node.js. label Jul 1, 2024
@KostiantynO KostiantynO changed the title Suggestion: split node.js docs into sections like react.dev doc: remove scroll up when highlighting text Jul 3, 2024
@KostiantynO
Copy link
Author

Oh, thank you! So, people already submitted a PR for node 22 and 17, and are waiting for review.
So, this scroll-padding-top on body is to show header in correct position?

P.S. It is fun that backend docs site suffer from pesky CSS bugs :D

@jwueller
Copy link
Contributor

jwueller commented Jul 13, 2024

So, this scroll-padding-top on body is to show header in correct position?

Yes. If the browser were to just scroll the target to the top, like it usually would, it would end up behind the header. This padding basically tells the browser that the visible region starts a bit further down, so scrolling things into view works as expected.

@RedYetiDev
Copy link
Member

I've closed this issue, as I think it's been resolved by a PR, if that's not the case, let me know and I'll reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants