Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21.0.0 fails to build on riscv64 #50267

Closed
q66 opened this issue Oct 19, 2023 · 5 comments
Closed

21.0.0 fails to build on riscv64 #50267

q66 opened this issue Oct 19, 2023 · 5 comments
Labels
riscv64 Issues and PRs related to the riscv64 architecture.

Comments

@q66
Copy link

q66 commented Oct 19, 2023

Version

21.1.0

Platform

Linux riscv64

Subsystem

v8

What steps will reproduce the bug?

Build node on riscv64

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Node builds

What do you see instead?

Node fails to build

Additional information

Build log: https://build.chimera-linux.org/#/builders/1/builds/631/steps/5/logs/pkg_contrib_nodejs_21_0_0-r0

It seems to be a forgotten upstream commit: chimera-linux/cports@a9665d0

Build log with patch: https://build.chimera-linux.org/#/builders/1/builds/632/steps/5/logs/pkg_contrib_nodejs_21_0_0-r0

@targos targos added the riscv64 Issues and PRs related to the riscv64 architecture. label Oct 19, 2023
@sxa
Copy link
Member

sxa commented Oct 19, 2023

We're seeing a failure on our unofficial build logs at https://unofficial-builds.nodejs.org/logs/202310171610-v21.0.0/riscv64.log too
ping @luyahan: Is this something you're aware of?

@luyahan
Copy link
Contributor

luyahan commented Nov 10, 2023

pr #50552 fix this.

@sxa
Copy link
Member

sxa commented Nov 10, 2023

pr #50552 fix this.

Thank you!

@targos
Copy link
Member

targos commented Nov 12, 2023

Will be fixed in v21.2.0: #50681

@targos targos closed this as completed Nov 12, 2023
@iggy
Copy link

iggy commented Jan 16, 2024

This got backported to 20.x which subsequently broke the build there because the v8 versions are different (11.3.244 vs 11.8.173)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
riscv64 Issues and PRs related to the riscv64 architecture.
Projects
None yet
Development

No branches or pull requests

5 participants