-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application (Marp) is broken after upgrading from 18.17.0 to 18.18.0 #49850
Comments
What path did you pass to fs.readFile()? If it includes special characters, then please post it verbatim; it might be an encoding issue. |
I executed with the absolute path and it's the same error marp -s -I C:\Users\tb10dcc\workspace\GOMAHTalk I think that this is the path that is passed to |
Can you do better than "I think"? Ideally try whittling it down to a test case that's only a few lines without third-party code. Bug reports that consist of "please look at my thousands of lines of code" usually don't go anywhere. |
@bnoordhuis Thank you for looking into this issue ☺. I'm not responsible of the |
I am the author of the Node.js application that received an original Issue mentioned above. @chrisdecker1201 I don't have the psychic ability to see through the structure in your folder, so I can't do anything with current information. Please share more specific path to the actual document file where the error occurs, not the path to the folder. Then, it should be able to create a minimal reproduction if the encoding is the actual cause. |
@yhatt Thank you for your time :). I narrowed it down to the following. Sorry for the bad error description. I have a file in the folder with the name In 18.17.0 this was no Problem. In 18.18.0 this leads to the error message mentioned. |
That sounds like #48673, #48673 (comment) in particular. Do you agree? If yes, it's best to close this issue and continue in the other one. |
Yes. Thank you :) |
Version
18.18.0
Platform
Microsoft Windows NT 10.0.19045.0 x64
Subsystem
No response
What steps will reproduce the bug?
I first created a bug here: marp-team/marp-cli#546, but it seems to be an issue with NodeJS.
nodejs-lts
18.17.0 withchoco
marp-cli
marp -s -I .
marp -s -I .
How often does it reproduce? Is there a required condition?
Everytime
What is the expected behavior? Why is that the expected behavior?
The same like in nodejs 18.17.0
What do you see instead?
Additional information
No response
The text was updated successfully, but these errors were encountered: