New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown file type names returns a wrong typo #49293

Closed

0o001 opened this issue Aug 23, 2023 · 1 comment

Labels

feature request

Contributor

0o001 commented Aug 23, 2023

What is the problem this feature will solve?

https://github.com/nodejs/node/blob/main/src/node_dir.cc#L56
https://github.com/nodejs/node/blob/main/src/node_file.cc#L159

What is the feature you are proposing to solve the problem?

https://github.com/nodejs/node/pull/49239/files

What alternatives have you considered?

No response

0o001 added the feature request label

0o001 mentioned this issue

src: fix fs_type_to_name default value #49239

Merged

Contributor

aduh95 commented Aug 28, 2023

Thanks for the PR, next time don't hesitate to not open an issue, the PR is more than enough.

aduh95 closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment