crypto: State not recovered after an exception is thrown

[jiripospisil]

While upgrading one of our applications to Node.js 4.2.6 (from 4.2.3) I bumped into an issue with the crypto module. In the tests, we supply an invalid key into the createCipheriv function and it barks as expected.

However, when running the same code again later in the tests, this time with a correct key, it still doesn't work and an exception is thrown. It weird thing is that the error comes from a different crypto function (createHash). I assume some internal state is not being cleared.

The code works on Node.js 4.2.3 and fails on 4.2.4-6. It's still entirely possible that we're doing something wrong. Any suggestions are welcomed.

https://gist.github.com/jiripospisil/70450ba715a004a11623

[evanlucas]

@jiripospisil this should have been fixed in v4.2.5. Mind giving that one a try to confirm?

[evanlucas]

ah, nevermind. Didn't see the -6 :[.

/cc @indutny ?

[bnoordhuis]

761cf2b from #4731 fixes this. I tagged it lts-watch-v4.x the other day, it should be in the next LTS release. I'll close the issue but let me know if you have questions.

[MylesBorins]

I'll make sure this lands

[MylesBorins]

I've gone ahead and landed that commit on v4.x-staging.

[jiripospisil]

Thank you guys for looking into it 👍

[jiripospisil]

@thealphanerd There's a new LTS release but the issue doesn't seem to be resolved. Was the fix included in the 4.3.0 version?

https://gist.github.com/jiripospisil/5d52e1404e870203c794

[jiripospisil]

/ping @evanlucas @bnoordhuis

[bnoordhuis]

@jiripospisil The last LTS release was a security release. The fix for this issue is scheduled for tomorrow's bug fix release.