-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: stream state after unpipe is undocumented #4812
Comments
@ronkorving @nodejs/documentation Does this material in the docs adequately address this?
|
Oh, there's this too. Not sure this addresses the issue here or not. Does it?
|
This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that. |
From your quotes, I think the docs are probably quite a bit better now. I'm happy 👍 |
The documentation doesn't mention whether unpipe leaves the stream in flowing mode, or whether a manual resume is needed. If it could mention that, I think that would be helpful. It would also be good to clarify under which circumstances (eg: always vs. when the last pipe has been removed vs. as-long-as-there-are-data-listeners etc...).
The text was updated successfully, but these errors were encountered: